[Nav Experiment] Update FormsTestCase setup for WKBasedNavigationManger.

These tests currently assume that the repost confirmation dialog is
shown on back/forward navigation. This is not true for
WKBasedNavigationManager because it matches WKWebView behavior, which
uses back/forward cache for back/forward navigation. This CL adds
|reload| to explicitly trigger the repost confirmation dialog.

Bug: 874635
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I24dafdd02014184f3fbc5b86f1026ebe8f5f00c7
Reviewed-on: https://chromium-review.googlesource.com/1243323
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593965}

ios/chrome/browser/web/forms_egtest.mm

@@ -250,6 +250,15 @@ id<GREYMatcher> ResendPostButtonMatcher() {
   // Go to a new page and go back and check that the data is reposted.
   [ChromeEarlGrey loadURL:GetGenericUrl()];
   [ChromeEarlGrey goBack];
+
+  // WKBasedNavigationManager doesn't triggere repost on |goForward| due to
+  // WKWebView's back-forward cache. Force reload to trigger repost. Not using
+  // [ChromeEarlGrey reload] because WKBasedNavigationManager presents repost
+  // confirmation dialog before loading stops.
+  if (web::GetWebClient()->IsSlimNavigationManagerEnabled()) {
+    [chrome_test_util::BrowserCommandDispatcherForMainBVC() reload];
+  }
+
   [self confirmResendWarning];
   [ChromeEarlGrey waitForWebViewContainingText:kDestinationText];
   [[EarlGrey selectElementWithMatcher:OmniboxText(destinationURL.GetContent())]
@@ -271,6 +280,15 @@ id<GREYMatcher> ResendPostButtonMatcher() {
 
   [ChromeEarlGrey goBack];
   [ChromeEarlGrey goForward];
+
+  // WKBasedNavigationManager doesn't triggere repost on |goForward| due to
+  // WKWebView's back-forward cache. Force reload to trigger repost. Not using
+  // [ChromeEarlGrey reload] because WKBasedNavigationManager presents repost
+  // confirmation dialog before loading stops.
+  if (web::GetWebClient()->IsSlimNavigationManagerEnabled()) {
+    [chrome_test_util::BrowserCommandDispatcherForMainBVC() reload];
+  }
+
   [self confirmResendWarning];
   [ChromeEarlGrey waitForWebViewContainingText:kDestinationText];
   [[EarlGrey selectElementWithMatcher:OmniboxText(destinationURL.GetContent())]
@@ -325,16 +343,38 @@ id<GREYMatcher> ResendPostButtonMatcher() {
   [ChromeEarlGrey goBack];
   [ChromeEarlGrey goForward];
 
+  // WKBasedNavigationManager doesn't triggere repost on |goForward| due to
+  // WKWebView's back-forward cache. Force reload to trigger repost. Not using
+  // [ChromeEarlGrey reload] because WKBasedNavigationManager presents repost
+  // confirmation dialog before loading stops.
+  if (web::GetWebClient()->IsSlimNavigationManagerEnabled()) {
+    [chrome_test_util::BrowserCommandDispatcherForMainBVC() reload];
+  }
+
   [[EarlGrey selectElementWithMatcher:ElementToDismissAlert(@"Cancel")]
       performAction:grey_tap()];
   [ChromeEarlGrey waitForPageToFinishLoading];
 
-  // Verify that navigation was cancelled, and forward navigation is possible.
-  [ChromeEarlGrey waitForWebViewContainingText:kSubmitButtonLabel];
-  [[EarlGrey selectElementWithMatcher:OmniboxText(GetFormUrl().GetContent())]
-      assertWithMatcher:grey_notNil()];
-  [[EarlGrey selectElementWithMatcher:chrome_test_util::ForwardButton()]
-      assertWithMatcher:grey_interactable()];
+  // Expected behavior is different between the two navigation manager
+  // implementations.
+  if (!web::GetWebClient()->IsSlimNavigationManagerEnabled()) {
+    // LegacyNavigationManager displays repost on |goBack|. So after cancelling,
+    // web view should show form URL.
+    [ChromeEarlGrey waitForWebViewContainingText:kSubmitButtonLabel];
+    [[EarlGrey selectElementWithMatcher:OmniboxText(GetFormUrl().GetContent())]
+        assertWithMatcher:grey_notNil()];
+    [[EarlGrey selectElementWithMatcher:chrome_test_util::ForwardButton()]
+        assertWithMatcher:grey_interactable()];
+  } else {
+    // WKBasedNavigationManager displays repost on |reload|. So after
+    // cancelling, web view should show |destinationURL|.
+    [ChromeEarlGrey waitForWebViewContainingText:kDestinationText];
+    [[EarlGrey
+        selectElementWithMatcher:OmniboxText(destinationURL.GetContent())]
+        assertWithMatcher:grey_notNil()];
+    [[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
+        assertWithMatcher:grey_interactable()];
+  }
 }
 
 // A new navigation dismisses the repost dialog.

ios/web/web_state/ui/crw_web_controller.mm

@@ -4358,6 +4358,7 @@ registerLoadRequestForURL:(const GURL&)requestURL
               decisionHandler(WKNavigationActionPolicyCancel);
               if (action.targetFrame.mainFrame) {
                 [_pendingNavigationInfo setCancelled:YES];
+                _webStateImpl->SetIsLoading(false);
               }
             }
           }));