Commit ced31122 authored by nhiroki's avatar nhiroki Committed by Commit bot

WebUI: Disable flaky WebUITests on Linux

These tests are frequently timed out on Linux Tests (dbg)

BUG=579666
TBR=dbeam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1617623002

Cr-Commit-Position: refs/heads/master@{#370651}
parent 38a8b698
......@@ -18,7 +18,7 @@ ContentSettingsExceptionAreaWebUITest.prototype = {
browsePreload: 'chrome://settings-frame/contentExceptions',
};
// See crbug.com/579830 for OS_LINUX
// See crbug.com/579666 for OS_LINUX
GEN('#if defined(OS_CHROMEOS) || defined(OS_LINUX)');
GEN('#define MAYBE_testOpenContentSettingsExceptionArea ' +
'DISABLED_testOpenContentSettingsExceptionArea');
......
......@@ -19,7 +19,7 @@ SearchEngineManagerWebUITest.prototype = {
};
// See crosbug.com/22673 for OS_CHROMEOS
// See crbug.com/579827 for OS_LINUX
// See crbug.com/579666 for OS_LINUX
GEN('#if defined(OS_CHROMEOS) || defined(OS_LINUX)');
GEN('#define MAYBE_testOpenSearchEngineManager ' +
'DISABLED_testOpenSearchEngineManager');
......
......@@ -20,8 +20,14 @@ SettingsAppWebUITest.prototype = {
GEN('#if defined(ENABLE_SETTINGS_APP)');
// This test is flaky on Linux bot. See crbug.com/579666
GEN('#if defined(OS_LINUX)');
GEN('#define MAYBE_testOpenSettingsApp DISABLED_testOpenSettingsApp');
GEN('#else');
GEN('#define MAYBE_testOpenSettingsApp testOpenSettingsApp');
GEN('#endif // defined(OS_LINUX)');
// Test opening Settings App, and do some checks on section visibility.
TEST_F('SettingsAppWebUITest', 'testOpenSettingsApp', function() {
TEST_F('SettingsAppWebUITest', 'MAYBE_testOpenSettingsApp', function() {
// Note there is no location bar in the Settings App.
// Some things are hidden via a parent, so make a helper function.
......@@ -41,10 +47,16 @@ TEST_F('SettingsAppWebUITest', 'testOpenSettingsApp', function() {
assertFalse(isVisible('startup-section'));
});
// This test is flaky on Linux bot. See crbug.com/579666
GEN('#if defined(OS_LINUX)');
GEN('#define MAYBE_testStrings DISABLED_testStrings');
GEN('#else');
GEN('#define MAYBE_testStrings testStrings');
GEN('#endif // defined(OS_LINUX)');
// Check functionality of LoadTimeData.overrideValues(), which the Settings App
// uses. Do spot checks, so the test is not too fragile. Some of the content
// strings rely on waiting for sync sign-in status, or platform-specifics.
TEST_F('SettingsAppWebUITest', 'testStrings', function() {
TEST_F('SettingsAppWebUITest', 'MAYBE_testStrings', function() {
// Ensure we check against the override values.
assertTrue(!!loadTimeData.getValue('settingsApp'));
......
......@@ -81,7 +81,13 @@ SyncSetupWebUITestAsync.prototype = {
},
};
TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {
// This test is flaky on Linux bot. See crbug.com/579666
GEN('#if defined(OS_LINUX)');
GEN('#define MAYBE_VerifySignIn DISABLED_VerifySignIn');
GEN('#else');
GEN('#define MAYBE_VerifySignIn VerifySignIn');
GEN('#endif // defined(OS_LINUX)');
TEST_F('SyncSetupWebUITestAsync', 'MAYBE_VerifySignIn', function() {
// Handle SyncSetupStartSignIn by displaying the sync setup dialog, verifying
// that a confirmation dialog appears, and clicking OK to dismiss the dialog.
// Note that this test doesn't actually do a gaia sign in.
......@@ -101,8 +107,14 @@ TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {
this.startSyncing();
});
// This test is flaky on Linux bot. See crbug.com/579666
GEN('#if defined(OS_LINUX)');
GEN('#define MAYBE_RestoreSyncDataTypes DISABLED_RestoreSyncDataTypes');
GEN('#else');
GEN('#define MAYBE_RestoreSyncDataTypes RestoreSyncDataTypes');
GEN('#endif // defined(OS_LINUX)');
// Test that switching to and from "Sync everything" saves and restores types.
TEST_F('SyncSetupWebUITestAsync', 'RestoreSyncDataTypes', function() {
TEST_F('SyncSetupWebUITestAsync', 'MAYBE_RestoreSyncDataTypes', function() {
this.mockHandler.expects(once()).SyncSetupStartSignIn(
'access-point-settings').will(callFunction(function() {
SyncSetupOverlay.showSyncSetupPage('configure', {});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment