Commit cedac690 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions] Update ChromeLauncherControllerTests to manifest v2

ChromeLauncherControllerTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: Ibe3aba811e68240bd5338aef9268af83bd611acc
Reviewed-on: https://chromium-review.googlesource.com/1026084Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553205}
parent 6c75fd3d
......@@ -104,7 +104,6 @@
#include "extensions/browser/app_window/native_app_window.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/switches.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/client/window_parenting_client.h"
#include "ui/aura/window.h"
......@@ -387,10 +386,6 @@ class ChromeLauncherControllerTest : public BrowserWithTestWindowTest {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
command_line->AppendSwitch(switches::kUseFirstDisplayAsInternal);
// TODO(devlin): Remove this. See https://crbug.com/816679.
command_line->AppendSwitch(
extensions::switches::kAllowLegacyExtensionManifests);
app_list::AppListSyncableServiceFactory::SetUseInTesting();
BrowserWithTestWindowTest::SetUp();
......@@ -403,6 +398,7 @@ class ChromeLauncherControllerTest : public BrowserWithTestWindowTest {
manifest.SetString(extensions::manifest_keys::kName,
"launcher controller test extension");
manifest.SetString(extensions::manifest_keys::kVersion, "1");
manifest.SetInteger(extensions::manifest_keys::kManifestVersion, 2);
manifest.SetString(extensions::manifest_keys::kDescription,
"for testing pinned apps");
......@@ -455,6 +451,7 @@ class ChromeLauncherControllerTest : public BrowserWithTestWindowTest {
manifest_gmail.SetString(extensions::manifest_keys::kName,
"Gmail launcher controller test extension");
manifest_gmail.SetString(extensions::manifest_keys::kVersion, "1");
manifest_gmail.SetInteger(extensions::manifest_keys::kManifestVersion, 2);
manifest_gmail.SetString(extensions::manifest_keys::kDescription,
"for testing pinned Gmail");
manifest_gmail.SetString(extensions::manifest_keys::kLaunchWebURL,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment