Commit ceffe540 authored by K. Moon's avatar K. Moon Committed by Commit Bot

Drop build support for non-PDFium engines

Removes support from pdf/BUILD.gn for building with PDF engines other
than PDFium. We do not intend to support other PDF engines going
forward.

Bug: 1076554
Change-Id: Id85f685001cc338bc8839f6f168a738ba4ed338d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302910
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: default avatarDaniel Hosseinian <dhoss@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789652}
parent 2389c8be
...@@ -16,14 +16,10 @@ buildflag_header("buildflags") { ...@@ -16,14 +16,10 @@ buildflag_header("buildflags") {
} }
if (enable_pdf) { if (enable_pdf) {
pdf_engine = 0 # 0 PDFium
config("pdf_common_config") { config("pdf_common_config") {
configs = [ "//build/config/compiler:noshadowing" ] configs = [ "//build/config/compiler:noshadowing" ]
if (pdf_engine == 0) { include_dirs = [ "//third_party/pdfium" ]
include_dirs = [ "//third_party/pdfium" ]
}
} }
static_library("pdf") { static_library("pdf") {
...@@ -60,6 +56,31 @@ if (enable_pdf) { ...@@ -60,6 +56,31 @@ if (enable_pdf) {
"pdf_init.h", "pdf_init.h",
"pdf_transform.cc", "pdf_transform.cc",
"pdf_transform.h", "pdf_transform.h",
"pdfium/pdfium_api_string_buffer_adapter.cc",
"pdfium/pdfium_api_string_buffer_adapter.h",
"pdfium/pdfium_assert_matching_enums.cc",
"pdfium/pdfium_document.cc",
"pdfium/pdfium_document.h",
"pdfium/pdfium_engine.cc",
"pdfium/pdfium_engine.h",
"pdfium/pdfium_engine_exports.cc",
"pdfium/pdfium_engine_exports.h",
"pdfium/pdfium_form_filler.cc",
"pdfium/pdfium_form_filler.h",
"pdfium/pdfium_mem_buffer_file_read.cc",
"pdfium/pdfium_mem_buffer_file_read.h",
"pdfium/pdfium_mem_buffer_file_write.cc",
"pdfium/pdfium_mem_buffer_file_write.h",
"pdfium/pdfium_page.cc",
"pdfium/pdfium_page.h",
"pdfium/pdfium_permissions.cc",
"pdfium/pdfium_permissions.h",
"pdfium/pdfium_print.cc",
"pdfium/pdfium_print.h",
"pdfium/pdfium_range.cc",
"pdfium/pdfium_range.h",
"pdfium/pdfium_unsupported_features.cc",
"pdfium/pdfium_unsupported_features.h",
"ppapi_migration/bitmap.cc", "ppapi_migration/bitmap.cc",
"ppapi_migration/bitmap.h", "ppapi_migration/bitmap.h",
"ppapi_migration/callback.cc", "ppapi_migration/callback.cc",
...@@ -91,56 +112,23 @@ if (enable_pdf) { ...@@ -91,56 +112,23 @@ if (enable_pdf) {
":features", ":features",
"//base", "//base",
"//base:i18n", "//base:i18n",
"//gin",
"//net", "//net",
"//pdf/pdfium/fuzzers",
"//ppapi/cpp:objects", "//ppapi/cpp:objects",
"//ppapi/cpp/private:internal_module", "//ppapi/cpp/private:internal_module",
"//printing",
"//skia", "//skia",
"//third_party/pdfium",
"//ui/base", "//ui/base",
"//ui/gfx/range", "//ui/gfx/range",
] ]
if (pdf_engine == 0) { if (is_linux) {
sources += [ sources += [
"pdfium/pdfium_api_string_buffer_adapter.cc", "pdfium/pdfium_font_linux.cc",
"pdfium/pdfium_api_string_buffer_adapter.h", "pdfium/pdfium_font_linux.h",
"pdfium/pdfium_assert_matching_enums.cc",
"pdfium/pdfium_document.cc",
"pdfium/pdfium_document.h",
"pdfium/pdfium_engine.cc",
"pdfium/pdfium_engine.h",
"pdfium/pdfium_engine_exports.cc",
"pdfium/pdfium_engine_exports.h",
"pdfium/pdfium_form_filler.cc",
"pdfium/pdfium_form_filler.h",
"pdfium/pdfium_mem_buffer_file_read.cc",
"pdfium/pdfium_mem_buffer_file_read.h",
"pdfium/pdfium_mem_buffer_file_write.cc",
"pdfium/pdfium_mem_buffer_file_write.h",
"pdfium/pdfium_page.cc",
"pdfium/pdfium_page.h",
"pdfium/pdfium_permissions.cc",
"pdfium/pdfium_permissions.h",
"pdfium/pdfium_print.cc",
"pdfium/pdfium_print.h",
"pdfium/pdfium_range.cc",
"pdfium/pdfium_range.h",
"pdfium/pdfium_unsupported_features.cc",
"pdfium/pdfium_unsupported_features.h",
] ]
deps += [
"//gin",
"//pdf/pdfium/fuzzers",
"//printing",
"//third_party/pdfium",
]
if (is_linux) {
sources += [
"pdfium/pdfium_font_linux.cc",
"pdfium/pdfium_font_linux.h",
]
}
} }
} }
...@@ -209,10 +197,23 @@ if (enable_pdf) { ...@@ -209,10 +197,23 @@ if (enable_pdf) {
"out_of_process_instance_unittest.cc", "out_of_process_instance_unittest.cc",
"page_orientation_unittest.cc", "page_orientation_unittest.cc",
"pdf_transform_unittest.cc", "pdf_transform_unittest.cc",
"pdfium/accessibility_unittest.cc",
"pdfium/findtext_unittest.cc",
"pdfium/pdfium_engine_exports_unittest.cc",
"pdfium/pdfium_engine_unittest.cc",
"pdfium/pdfium_form_filler_unittest.cc",
"pdfium/pdfium_page_unittest.cc",
"pdfium/pdfium_permissions_unittest.cc",
"pdfium/pdfium_print_unittest.cc",
"pdfium/pdfium_test_base.cc",
"pdfium/pdfium_test_base.h",
"range_set_unittest.cc", "range_set_unittest.cc",
] ]
configs += [ ":pdf_common_config" ] configs += [
":pdf_common_config",
"//v8:external_startup_data",
]
data = [ "test/data/" ] data = [ "test/data/" ]
...@@ -223,40 +224,20 @@ if (enable_pdf) { ...@@ -223,40 +224,20 @@ if (enable_pdf) {
"//base", "//base",
"//base/test:run_all_unittests", "//base/test:run_all_unittests",
"//base/test:test_support", "//base/test:test_support",
"//gin",
"//ppapi/c", "//ppapi/c",
"//ppapi/cpp:objects", "//ppapi/cpp:objects",
"//printing", "//printing",
"//skia", "//skia",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/pdfium",
"//ui/gfx/geometry", "//ui/gfx/geometry",
"//ui/gfx/range", "//ui/gfx/range",
] ]
if (pdf_engine == 0) { if (v8_use_external_startup_data) {
sources += [ data += [ "$root_out_dir/snapshot_blob.bin" ]
"pdfium/accessibility_unittest.cc",
"pdfium/findtext_unittest.cc",
"pdfium/pdfium_engine_exports_unittest.cc",
"pdfium/pdfium_engine_unittest.cc",
"pdfium/pdfium_form_filler_unittest.cc",
"pdfium/pdfium_page_unittest.cc",
"pdfium/pdfium_permissions_unittest.cc",
"pdfium/pdfium_print_unittest.cc",
"pdfium/pdfium_test_base.cc",
"pdfium/pdfium_test_base.h",
]
configs += [ "//v8:external_startup_data" ]
deps += [
"//gin",
"//third_party/pdfium",
]
if (v8_use_external_startup_data) {
data += [ "$root_out_dir/snapshot_blob.bin" ]
}
} }
} }
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment