Commit cf1a1a6d authored by Pavol Marko's avatar Pavol Marko Committed by Chromium LUCI CQ

device_management_service: Transform ifs to switch-case

Transform the sequence of ifs to set authentication headers to a
switch-case over the token type.

Bug: none
Change-Id: Id636342873c77f76cf6adb8abe7f5668c448b2b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567219
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: default avatarMichael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#835619}
parent 1a09ac4c
......@@ -299,22 +299,29 @@ JobConfigurationBase::GetResourceRequest(bool bypass_proxy, int last_error) {
rr->trusted_params->disable_secure_dns = true;
// If auth data is specified, use it to build the request.
if (auth_data_.has_gaia_token()) {
rr->headers.SetHeader(
dm_protocol::kAuthHeader,
std::string(dm_protocol::kServiceTokenAuthHeaderPrefix) +
auth_data_.gaia_token());
}
if (auth_data_.has_dm_token()) {
rr->headers.SetHeader(dm_protocol::kAuthHeader,
std::string(dm_protocol::kDMTokenAuthHeaderPrefix) +
auth_data_.dm_token());
}
if (auth_data_.has_enrollment_token()) {
rr->headers.SetHeader(
dm_protocol::kAuthHeader,
std::string(dm_protocol::kEnrollmentTokenAuthHeaderPrefix) +
auth_data_.enrollment_token());
switch (auth_data_.token_type()) {
case DMAuthTokenType::kNoAuth:
break;
case DMAuthTokenType::kGaia:
rr->headers.SetHeader(
dm_protocol::kAuthHeader,
std::string(dm_protocol::kServiceTokenAuthHeaderPrefix) +
auth_data_.gaia_token());
break;
case DMAuthTokenType::kDm:
rr->headers.SetHeader(dm_protocol::kAuthHeader,
std::string(dm_protocol::kDMTokenAuthHeaderPrefix) +
auth_data_.dm_token());
break;
case DMAuthTokenType::kEnrollment:
rr->headers.SetHeader(
dm_protocol::kAuthHeader,
std::string(dm_protocol::kEnrollmentTokenAuthHeaderPrefix) +
auth_data_.enrollment_token());
break;
case DMAuthTokenType::kOauth:
// OAuth token is transferred as a HTTP query parameter.
break;
}
return rr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment