Commit cf817e13 authored by Clark DuVall's avatar Clark DuVall Committed by Chromium LUCI CQ

Cleanup unused isolated splits gn params

The supports_isolated_split arg is no longer needed since all DFMs
support isolated splits.

Bug: 1126301
Change-Id: Idf1ef64bec372f21efd68cb9d05933690cf8b1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617118
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841309}
parent 5fe6f459
......@@ -2344,7 +2344,6 @@ template("monochrome_public_apk_or_module_tmpl") {
"include_64_bit_webview",
"is_64_bit_browser",
"is_base_module",
"module_descs",
"resource_ids_provider_dep",
"static_library_provider",
"static_library_synchronized_proguard",
......@@ -2996,9 +2995,6 @@ template("monochrome_or_trichrome_public_bundle_tmpl") {
target_type = "android_app_bundle_module"
is_base_module = true
version_code = _version_code
if (enable_chrome_module) {
module_descs = _module_descs
}
if (!_is_trichrome ||
!defined(invoker.static_library_synchronized_proguard) ||
......
......@@ -464,9 +464,6 @@ template("monochrome_public_common_apk_or_module_tmpl") {
_enable_chrome_module =
_is_bundle_module && invoker.is_base_module && enable_chrome_module
if (_enable_chrome_module) {
# TODO(crbug.com/1150459): Remove this once internal repo is updated.
not_needed(invoker, [ "module_descs" ])
# If the manifest is being verified, add the chrome module's manifest.
if (defined(invoker.expected_android_manifest)) {
_bundle_target_gen_dir =
......
......@@ -19,5 +19,4 @@ dev_ui_module_desc = {
# DevUI DFM does not need to call Module.getImpl(), and manages loading on
# install and on use. Therefore disable auto-load on Module.getImpl().
load_native_on_get_impl = false
supports_isolated_split = true
}
......@@ -40,8 +40,6 @@ if (enable_arcore) {
# library files going into module if the module is executed in 64 bit.
# pak_deps: (Optional) Grit or repack targets of PAKs going into module.
# paks: (Optional) PAKs going into module.
# supports_isolated_split: (Optional) Whether this module can be in its own
# isolated split.
# Each new module needs to add a desc to one of the lists below.
# Modules shipped in Chrome Modern (Android L+).
......
......@@ -10,5 +10,4 @@ extra_icu_module_desc = {
"//chrome/android/modules/extra_icu/internal:java",
"//third_party/icu:icu_extra_assets",
]
supports_isolated_split = true
}
......@@ -10,5 +10,4 @@ stack_unwinder_module_desc = {
java_deps = [ "//chrome/android/modules/stack_unwinder/internal:java" ]
native_deps = [ "//chrome/android/modules/stack_unwinder/internal:native" ]
load_native_on_get_impl = false
supports_isolated_split = true
}
......@@ -19,5 +19,4 @@ test_dummy_module_desc = {
paks = [ "$root_gen_dir/chrome/test_dummy_resources.pak" ]
pak_deps = [ "//chrome/browser/test_dummy/internal:resources_native" ]
load_native_on_get_impl = true
supports_isolated_split = true
}
......@@ -5,5 +5,4 @@
weblayer_module_desc = {
name = "weblayer"
android_manifest = "//weblayer/browser/java/AndroidManifest_monochrome.xml"
supports_isolated_split = true
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment