Commit cf877929 authored by eseidel@chromium.org's avatar eseidel@chromium.org

Remove checkout functionality from GOM

Some folks still probably run GOM locally, but
it's not worth the burden on the code to keep this around.
If we want this we should re-build it to be web only.

R=abarth@chromium.org, abarth, dpranke
BUG=389681

Review URL: https://codereview.chromium.org/355193005

git-svn-id: svn://svn.chromium.org/blink/trunk@177140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 11bfb9d1
...@@ -49,7 +49,6 @@ James, a web developer from Birmingham, UK. ...@@ -49,7 +49,6 @@ James, a web developer from Birmingham, UK.
<script src="scripts/svn-log.js"></script> <script src="scripts/svn-log.js"></script>
<script src="scripts/treestatus.js"></script> <script src="scripts/treestatus.js"></script>
<script src="scripts/builders.js"></script> <script src="scripts/builders.js"></script>
<script src="scripts/checkout.js"></script>
<script src="scripts/results.js"></script> <script src="scripts/results.js"></script>
<script src="scripts/ui.js"></script> <script src="scripts/ui.js"></script>
<script src="scripts/model.js"></script> <script src="scripts/model.js"></script>
......
...@@ -53,8 +53,6 @@ THE POSSIBILITY OF SUCH DAMAGE. ...@@ -53,8 +53,6 @@ THE POSSIBILITY OF SUCH DAMAGE.
<script src="scripts/treestatus_unittests.js"></script> <script src="scripts/treestatus_unittests.js"></script>
<script src="scripts/builders.js"></script> <script src="scripts/builders.js"></script>
<script src="scripts/builders_unittests.js"></script> <script src="scripts/builders_unittests.js"></script>
<script src="scripts/checkout.js"></script>
<script src="scripts/checkout_unittests.js"></script>
<script src="scripts/results.js"></script> <script src="scripts/results.js"></script>
<script src="scripts/results_unittests.js"></script> <script src="scripts/results_unittests.js"></script>
<script src="scripts/ui.js"></script> <script src="scripts/ui.js"></script>
......
/*
* Copyright (C) 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
* THE POSSIBILITY OF SUCH DAMAGE.
*/
var checkout = checkout || {};
(function() {
var g_haveSeenCheckoutAvailable = false;
function checkoutAvailable()
{
if (g_haveSeenCheckoutAvailable) {
return Promise.resolve();
}
return checkout.isAvailable().then(function(isAvailable) {
if (isAvailable) {
g_haveSeenCheckoutAvailable = true;
return;
}
});
};
checkout.isAvailable = function()
{
return net.ajax({
url: '/ping',
}).then(function() { return true; },
function() { return false; });
};
checkout.lastBlinkRollRevision = function()
{
return checkoutAvailable().then(function() {
return net.get('/lastroll');
});
};
checkout.rollout = function(revision, reason)
{
return checkoutAvailable().then(function() {
return net.post('/rollout?' + $.param({
'revision': revision,
'reason': reason
}));
});
};
})();
/*
* Copyright (C) 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
* THE POSSIBILITY OF SUCH DAMAGE.
*/
(function () {
module("checkout");
asyncTest("lastBlinkRollRevision", 0, function() {
var simulator = new NetworkSimulator();
var requests = [];
simulator.get = function(url)
{
requests.push([url]);
return Promise.resolve();
};
simulator.ajax = function(options)
{
if (options.url.indexOf('/ping') == -1) {
ok(false, 'Received non-ping ajax request: ' + options.url);
return Promise.reject('Received non-ping ajax request: ' + options.url);
}
return Promise.resolve();
};
simulator.runTest(function() {
checkout.lastBlinkRollRevision(function() {
ok(true);
}, function() {
ok(false, 'Checkout should be available.');
});
}).then(function() {
deepEqual(requests, [
["/lastroll"]
]);
start();
});;
});
})();
...@@ -27,8 +27,6 @@ var controllers = controllers || {}; ...@@ -27,8 +27,6 @@ var controllers = controllers || {};
(function(){ (function(){
var kCheckoutUnavailableMessage = 'Failed! Garden-o-matic needs a local server to modify your working copy. Please run "webkit-patch garden-o-matic" start the local server.';
// FIXME: This is duplicated from ui/results.js :(. // FIXME: This is duplicated from ui/results.js :(.
function isAnyReftest(testName, resultsByTest) function isAnyReftest(testName, resultsByTest)
{ {
...@@ -48,12 +46,6 @@ function updateExpectationsWithStatusUpdates(failureInfoList) ...@@ -48,12 +46,6 @@ function updateExpectationsWithStatusUpdates(failureInfoList)
var testNames = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; })); var testNames = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
var testName = testNames.length == 1 ? testNames[0] : testNames.length + ' tests'; var testName = testNames.length == 1 ? testNames[0] : testNames.length + ' tests';
statusView.addMessage(id, 'Updating expectations of ' + testName + '...'); statusView.addMessage(id, 'Updating expectations of ' + testName + '...');
checkout.updateExpectations(failureInfoList, function() {
statusView.addFinalMessage(id, 'Expectations update done! Please commit them locally and land with "git cl dcommit".');
}, function() {
statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
});
} }
controllers.ResultsDetails = base.extends(Object, { controllers.ResultsDetails = base.extends(Object, {
...@@ -222,13 +214,6 @@ controllers.UnexpectedFailures = base.extends(FailureStreamController, { ...@@ -222,13 +214,6 @@ controllers.UnexpectedFailures = base.extends(FailureStreamController, {
{ {
return this._testFailures.length(); return this._testFailures.length();
}, },
onRollout: function(revision, testNameList)
{
checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList)).then($.noop, function() {
// FIXME: We should have a better error UI.
alert(kCheckoutUnavailableMessage);
});
}
}); });
controllers.FailingBuilders = base.extends(Object, { controllers.FailingBuilders = base.extends(Object, {
......
...@@ -31,7 +31,6 @@ var kCommitLogLength = 50; ...@@ -31,7 +31,6 @@ var kCommitLogLength = 50;
model.state = {}; model.state = {};
model.state.failureAnalysisByTest = {}; model.state.failureAnalysisByTest = {};
model.state.expectationsUpdateQueue = [];
function findAndMarkRevertedRevisions(commitDataList) function findAndMarkRevertedRevisions(commitDataList)
{ {
...@@ -72,18 +71,6 @@ function heuristicallyNarrowRegressionRange(failureAnalysis) ...@@ -72,18 +71,6 @@ function heuristicallyNarrowRegressionRange(failureAnalysis)
} }
} }
model.queueForExpectationUpdate = function(failureInfo)
{
model.state.expectationsUpdateQueue.push(failureInfo);
};
model.takeExpectationUpdateQueue = function()
{
var queue = model.state.expectationsUpdateQueue;
model.state.expectationsUpdateQueue = [];
return queue;
};
var g_commitIndex = {}; var g_commitIndex = {};
model.updateRecentCommits = function() model.updateRecentCommits = function()
......
...@@ -410,11 +410,12 @@ ui.revisionDetails = base.extends('span', { ...@@ -410,11 +410,12 @@ ui.revisionDetails = base.extends('span', {
theSpan.appendChild(document.createTextNode(', trunk is at ')); theSpan.appendChild(document.createTextNode(', trunk is at '));
theSpan.appendChild(ui.createLinkNode(trac.changesetURL(totRevision), totRevision)); theSpan.appendChild(ui.createLinkNode(trac.changesetURL(totRevision), totRevision));
Promise.all([checkout.lastBlinkRollRevision(), rollbot.fetchCurrentRoll()]).then(function(results) { // We want this feature, but need to fetch the lastBlinkRollRevision via the interwebs.
theSpan.lastRolledRevision = results[0]; // Promise.all([checkout.lastBlinkRollRevision(), rollbot.fetchCurrentRoll()]).then(function(results) {
theSpan.roll = results[1]; // theSpan.lastRolledRevision = results[0];
theSpan.updateUI(totRevision); // theSpan.roll = results[1];
}); // theSpan.updateUI(totRevision);
// });
} }
}); });
......
...@@ -52,14 +52,6 @@ ui.actions.Close = base.extends(Action, { ...@@ -52,14 +52,6 @@ ui.actions.Close = base.extends(Action, {
} }
}); });
ui.actions.Rollout = base.extends(Action, {
init: function() {
this.textContent = 'Roll out';
this._eventName = 'rollout';
this.title = 'Rolls out this revision.'
}
});
ui.actions.Examine = base.extends(Action, { ui.actions.Examine = base.extends(Action, {
init: function() { init: function() {
this.textContent = 'Examine'; this.textContent = 'Examine';
......
...@@ -27,12 +27,8 @@ ...@@ -27,12 +27,8 @@
module('ui.actions'); module('ui.actions');
test('Buttons', 4, function() { test('Buttons', 2, function() {
var buttonInfos = [{ var buttonInfos = [{
view: new ui.actions.Rollout(),
text: 'Roll out',
event: 'rollout'
}, {
view: new ui.actions.Examine(), view: new ui.actions.Examine(),
text: 'Examine', text: 'Examine',
event: 'examine' event: 'examine'
......
...@@ -311,8 +311,8 @@ asyncTest("RevisionDetailsMediumRoll", 2, function() { ...@@ -311,8 +311,8 @@ asyncTest("RevisionDetailsMediumRoll", 2, function() {
'</table>' + '</table>' +
'</details>' + '</details>' +
', trunk is at <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=555">555</a>' + ', trunk is at <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=555">555</a>' +
'<br>' + '<br>';
'Last roll is to <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=500">500</a><span class="warning">(55 revisions behind)</span>, current autoroll <a href="https://codereview.chromium.org/1000">500:550</a>'); // 'Last roll is to <a href="http://src.chromium.org/viewvc/blink?view=rev&amp;revision=500">500</a><span class="warning">(55 revisions behind)</span>, current autoroll <a href="https://codereview.chromium.org/1000">500:550</a>');
start(); start();
}); });
}); });
......
...@@ -41,7 +41,6 @@ James, a web developer from Birmingham, UK. ...@@ -41,7 +41,6 @@ James, a web developer from Birmingham, UK.
<script src="scripts/net.js"></script> <script src="scripts/net.js"></script>
<script src="scripts/svn-log.js"></script> <script src="scripts/svn-log.js"></script>
<script src="scripts/builders.js"></script> <script src="scripts/builders.js"></script>
<script src="scripts/checkout.js"></script>
<script src="scripts/results.js"></script> <script src="scripts/results.js"></script>
<script src="scripts/ui.js"></script> <script src="scripts/ui.js"></script>
<script src="scripts/model.js"></script> <script src="scripts/model.js"></script>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment