Spare RunUntilIdle in PasswordStoreDefaultTest.Notifications
This CL removes intermediate calls of scoped_task_environment_.RunUntilIdle() from PasswordStoreDefaultTest.Notifications and only leaves the last one. This is enough to verify the test expectations and makes the test slightly faster in debug mode. Some local benchmarking showed that in debug configuration on my machine (Z620, Ubuntu) the test takes 45-50ms before the changes and about 40ms after it. No siginificant difference was perceived in release build. Thanks vasilii@ for spotting this test and suggesting this way of speeding it up. Bug: 788875 Change-Id: Ie9b3d6b65ef8a5f99400acc66c097360259e204e Reviewed-on: https://chromium-review.googlesource.com/803342Reviewed-by:Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521296}
Showing
Please register or sign in to comment