Downloads : Implemented OCP::OpenItem

Provided implementation for DownloadOfflineContentProvider::OpenItem. It
will call DownloadItem::OpenDownload and eventually hits
ChromeDownloadManagerDelegate. We will also need to pass DownloadOpenSource
to this interface later for UMA purposes.

Bug: 855727
Change-Id: I86f4f802ab8711ea2162e512e18cbcbf93c1822f
Reviewed-on: https://chromium-review.googlesource.com/1114068
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571580}

chrome/browser/android/download/download_manager_service.cc

@@ -204,6 +204,15 @@ void DownloadManagerService::Observe(
   }
 }
 
+void DownloadManagerService::OpenDownload(download::DownloadItem* download,
+                                          int source) {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  ScopedJavaLocalRef<jobject> j_item =
+      JNI_DownloadManagerService_CreateJavaDownloadItem(env, download);
+
+  Java_DownloadManagerService_openDownloadItem(env, java_ref_, j_item, source);
+}
+
 void DownloadManagerService::OpenDownload(
     JNIEnv* env,
     jobject obj,
@@ -222,10 +231,7 @@ void DownloadManagerService::OpenDownload(
   if (!item)
     return;
 
-  ScopedJavaLocalRef<jobject> j_item =
-      JNI_DownloadManagerService_CreateJavaDownloadItem(env, item);
-
-  Java_DownloadManagerService_openDownloadItem(env, java_ref_, j_item, source);
+  OpenDownload(item, source);
 }
 
 void DownloadManagerService::ResumeDownload(

chrome/browser/android/download/download_manager_service.h

@@ -57,6 +57,9 @@ class DownloadManagerService
   // Called to Initialize this object.
   void Init(JNIEnv* env, jobject obj);
 
+  // Called to open a given download item.
+  void OpenDownload(download::DownloadItem* download, int source);
+
   // Called to open a download item whose GUID is equal to |jdownload_guid|.
   void OpenDownload(JNIEnv* env,
                     jobject obj,

chrome/browser/download/chrome_download_manager_delegate.cc

@@ -640,6 +640,15 @@ void ChromeDownloadManagerDelegate::OpenDownload(DownloadItem* download) {
   MaybeSendDangerousDownloadOpenedReport(download,
                                          false /* show_download_in_folder */);
 
+#if defined(OS_ANDROID)
+  // TODO(shaktisahu@): Pull out to static helper method once
+  // DownloadManagerService goes away.  Put the helper method in the download
+  // component.
+  DownloadManagerService::GetInstance()->OpenDownload(download,
+                                                      0 /* download source */);
+  return;
+#endif
+
   if (!DownloadItemModel(download).ShouldPreferOpeningInBrowser()) {
     RecordDownloadOpenMethod(DOWNLOAD_OPEN_METHOD_DEFAULT_PLATFORM);
     OpenDownloadUsingPlatformHandler(download);

chrome/browser/download/download_offline_content_provider.cc

@@ -48,9 +48,11 @@ DownloadOfflineContentProvider::~DownloadOfflineContentProvider() {
       manager_->GetBrowserContext()->IsOffTheRecord()));
 }
 
+// TODO(shaktisahu) : Pass DownloadOpenSource.
 void DownloadOfflineContentProvider::OpenItem(const ContentId& id) {
-  // TODO(crbug.com/855727): Provide implementation.
-  NOTIMPLEMENTED();
+  download::DownloadItem* item = manager_->GetDownloadByGuid(id.id);
+  if (item)
+    item->OpenDownload();
 }
 
 void DownloadOfflineContentProvider::RemoveItem(const ContentId& id) {