Commit cfe6d397 authored by alexeypa@chromium.org's avatar alexeypa@chromium.org

[Chromoting] Fix remoting_host_installation wix actions.

Add commas between array elements and remove extra spaces at end.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/10264022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134683 0039d316-1c4b-4281-b951-d872f2087c98
parent 63942f25
...@@ -577,15 +577,14 @@ ...@@ -577,15 +577,14 @@
'outputs': [ 'outputs': [
'<(PRODUCT_DIR)/chromoting.msi', '<(PRODUCT_DIR)/chromoting.msi',
], ],
'wix_defines' : [
'"-dBranding=<(branding)"',
],
'conditions': [ 'conditions': [
['buildtype == "Official"', { ['buildtype == "Official"', {
'variables': { 'wix_defines': [
'official_build': '-dOfficialBuild=1', '-dOfficialBuild=1',
}, ],
}, { # else branding!="Chrome"
'variables': {
'official_build': '',
},
}], }],
], ],
'rules': [ 'rules': [
...@@ -596,7 +595,7 @@ ...@@ -596,7 +595,7 @@
'<(PRODUCT_DIR)/remoting_host_controller.exe', '<(PRODUCT_DIR)/remoting_host_controller.exe',
'<(PRODUCT_DIR)/remoting_me2me_host.exe', '<(PRODUCT_DIR)/remoting_me2me_host.exe',
'<(PRODUCT_DIR)/remoting_service.exe', '<(PRODUCT_DIR)/remoting_service.exe',
'<(platformsdk_path)/redist/x86/sas.dll' '<(platformsdk_path)/redist/x86/sas.dll',
], ],
'outputs': [ 'outputs': [
'<(INTERMEDIATE_DIR)/<(RULE_INPUT_ROOT).wixobj', '<(INTERMEDIATE_DIR)/<(RULE_INPUT_ROOT).wixobj',
...@@ -609,11 +608,10 @@ ...@@ -609,11 +608,10 @@
'-ext "<(wix_path)\\WixFirewallExtension.dll"', '-ext "<(wix_path)\\WixFirewallExtension.dll"',
'-ext "<(wix_path)\\WixUIExtension.dll"', '-ext "<(wix_path)\\WixUIExtension.dll"',
'-ext "<(wix_path)\\WixUtilExtension.dll"', '-ext "<(wix_path)\\WixUtilExtension.dll"',
'-dVersion=<(version_full) ' '-dVersion=<(version_full)',
'"-dFileSource=<(PRODUCT_DIR)." ' '"-dFileSource=<(PRODUCT_DIR)."',
'"-dSasDllPath=<(platformsdk_path)/redist/x86/sas.dll" ' '"-dSasDllPath=<(platformsdk_path)/redist/x86/sas.dll"',
'<(official_build) ' '<@(_wix_defines)',
'"-dBranding=<(branding)" '
'-out <@(_outputs)', '-out <@(_outputs)',
'"<(RULE_INPUT_PATH)"', '"<(RULE_INPUT_PATH)"',
], ],
...@@ -626,7 +624,7 @@ ...@@ -626,7 +624,7 @@
'<(PRODUCT_DIR)/remoting_host_controller.exe', '<(PRODUCT_DIR)/remoting_host_controller.exe',
'<(PRODUCT_DIR)/remoting_me2me_host.exe', '<(PRODUCT_DIR)/remoting_me2me_host.exe',
'<(PRODUCT_DIR)/remoting_service.exe', '<(PRODUCT_DIR)/remoting_service.exe',
'<(platformsdk_path)/redist/x86/sas.dll' '<(platformsdk_path)/redist/x86/sas.dll',
], ],
'outputs': [ 'outputs': [
'<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).msi', '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).msi',
...@@ -640,11 +638,10 @@ ...@@ -640,11 +638,10 @@
'-ext "<(wix_path)\\WixUIExtension.dll"', '-ext "<(wix_path)\\WixUIExtension.dll"',
'-ext "<(wix_path)\\WixUtilExtension.dll"', '-ext "<(wix_path)\\WixUtilExtension.dll"',
'-cultures:en-us', '-cultures:en-us',
'-dVersion=<(version_full) ' '-dVersion=<(version_full)',
'"-dFileSource=<(PRODUCT_DIR)." ' '"-dFileSource=<(PRODUCT_DIR)."',
'"-dSasDllPath=<(platformsdk_path)/redist/x86/sas.dll" ' '"-dSasDllPath=<(platformsdk_path)/redist/x86/sas.dll"',
'<(official_build) ' '<@(_wix_defines)',
'"-dBranding=<(branding)" '
'-out "<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).msi"', '-out "<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).msi"',
'"<(RULE_INPUT_PATH)"', '"<(RULE_INPUT_PATH)"',
], ],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment