Commit cffff2e9 authored by Maggie Cai's avatar Maggie Cai Committed by Commit Bot

[IntentHandling] Fix empty activity name issue.

Currently it is possible to have empty activity name return from intent
querying. Update the logic to return the app name if the activity name
is empty.

BUG=1092784

Change-Id: I4af2406b5627d8d68ac3d6ee7f03c0e7175116ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336008
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794909}
parent d7278ccc
...@@ -529,18 +529,17 @@ std::vector<AppIdAndActivityName> AppServiceProxy::GetAppsForIntent( ...@@ -529,18 +529,17 @@ std::vector<AppIdAndActivityName> AppServiceProxy::GetAppsForIntent(
if (apps_util::IntentMatchesFilter(intent, filter)) { if (apps_util::IntentMatchesFilter(intent, filter)) {
AppIdAndActivityName app_id_and_activity; AppIdAndActivityName app_id_and_activity;
app_id_and_activity.app_id = update.AppId(); app_id_and_activity.app_id = update.AppId();
if (base::FeatureList::IsEnabled(features::kIntentHandlingSharing) && std::string activity_name;
filter->activity_name.has_value()) { if (filter->activity_name && !filter->activity_name.value().empty()) {
std::string activity_name = filter->activity_name.value(); activity_name = filter->activity_name.value();
if (activity_name.empty()) { } else {
activity_name = update.Name(); activity_name = update.Name();
}
if (base::Contains(existing_activities, activity_name)) {
continue;
}
existing_activities.insert(activity_name);
app_id_and_activity.activity_name = activity_name;
} }
if (base::Contains(existing_activities, activity_name)) {
continue;
}
existing_activities.insert(activity_name);
app_id_and_activity.activity_name = activity_name;
app_id_and_activities.push_back(app_id_and_activity); app_id_and_activities.push_back(app_id_and_activity);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment