Commit d004e9fd authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Disable popups on page close for M80.

Bug: 1010509
Change-Id: I5e9a2efe97efe3d307fa4291ab42da61b0bbab5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881311Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709542}
parent d76b932a
...@@ -433,8 +433,6 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, ...@@ -433,8 +433,6 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
ASSERT_EQ(1, GetBlockedContentsCount()); ASSERT_EQ(1, GetBlockedContentsCount());
} }
// TODO(https://crbug.com/1010509): Re-enable this in Chrome 80.
#if 0
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, NoPopupsLaunchWhenTabIsClosed) { IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, NoPopupsLaunchWhenTabIsClosed) {
base::CommandLine::ForCurrentProcess()->AppendSwitch( base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisablePopupBlocking); switches::kDisablePopupBlocking);
...@@ -448,7 +446,6 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, NoPopupsLaunchWhenTabIsClosed) { ...@@ -448,7 +446,6 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, NoPopupsLaunchWhenTabIsClosed) {
// Expect no popup. // Expect no popup.
ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile())); ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile()));
} }
#endif
// This only exists for the AllowPopupsWhenTabIsClosedWithSpecialPolicy test. // This only exists for the AllowPopupsWhenTabIsClosedWithSpecialPolicy test.
// Remove this in Chrome 82. https://crbug.com/937569 // Remove this in Chrome 82. https://crbug.com/937569
......
...@@ -28,10 +28,9 @@ const base::Feature kAllowContentInitiatedDataUrlNavigations{ ...@@ -28,10 +28,9 @@ const base::Feature kAllowContentInitiatedDataUrlNavigations{
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
// Allows popups during page unloading. // Allows popups during page unloading.
// TODO(https://crbug.com/1010509): Set to DISABLED_BY_DEFAULT in Chrome 80.
// TODO(https://crbug.com/937569): Remove this entirely in Chrome 82. // TODO(https://crbug.com/937569): Remove this entirely in Chrome 82.
const base::Feature kAllowPopupsDuringPageUnload{ const base::Feature kAllowPopupsDuringPageUnload{
"AllowPopupsDuringPageUnload", base::FEATURE_ENABLED_BY_DEFAULT}; "AllowPopupsDuringPageUnload", base::FEATURE_DISABLED_BY_DEFAULT};
// Accepts Origin-Signed HTTP Exchanges to be signed with certificates // Accepts Origin-Signed HTTP Exchanges to be signed with certificates
// that do not have CanSignHttpExchangesDraft extension. // that do not have CanSignHttpExchangesDraft extension.
......
...@@ -3862,9 +3862,6 @@ crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/margin-collap ...@@ -3862,9 +3862,6 @@ crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/margin-collap
# Other untriaged test failures, timeouts and crashes from newly-imported WPT tests. # Other untriaged test failures, timeouts and crashes from newly-imported WPT tests.
crbug.com/626703 external/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html [ Failure Pass ] crbug.com/626703 external/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html [ Failure Pass ]
# TODO(https://crbug.com/1010509): Re-enable this in Chrome 80.
crbug.com/936080 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html [ Failure ]
# Underline offset and thickness are not implemented yet. # Underline offset and thickness are not implemented yet.
crbug.com/785230 external/wpt/css/css-text-decor/text-underline-offset-001.html [ Skip ] crbug.com/785230 external/wpt/css/css-text-decor/text-underline-offset-001.html [ Skip ]
crbug.com/785230 external/wpt/css/css-text-decor/text-underline-offset-scroll-001.html [ Skip ] crbug.com/785230 external/wpt/css/css-text-decor/text-underline-offset-scroll-001.html [ Skip ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment