Commit d01360ae authored by Tanya Gupta's avatar Tanya Gupta Committed by Chromium LUCI CQ

[LongScrenshots] Defined enum to be generated in native and java

Bug: 1142520
Change-Id: Ie584b49f19820c19f91a7b566f86fe6d3e1278f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566093Reviewed-by: default avatarKyle Milka <kmilka@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832593}
parent e6717228
...@@ -709,6 +709,7 @@ java_cpp_enum("chrome_android_java_enums_srcjar") { ...@@ -709,6 +709,7 @@ java_cpp_enum("chrome_android_java_enums_srcjar") {
"//chrome/browser/installable/digital_asset_links/digital_asset_links_handler.h", "//chrome/browser/installable/digital_asset_links/digital_asset_links_handler.h",
"//chrome/browser/installable/installed_webapp_geolocation_bridge.cc", "//chrome/browser/installable/installed_webapp_geolocation_bridge.cc",
"//chrome/browser/installable/quality_enforcer.cc", "//chrome/browser/installable/quality_enforcer.cc",
"//chrome/browser/long_screenshots/long_screenshots_tab_service.h",
"//chrome/browser/notifications/notification_channels_provider_android.h", "//chrome/browser/notifications/notification_channels_provider_android.h",
"//chrome/browser/notifications/notification_handler.h", "//chrome/browser/notifications/notification_handler.h",
"//chrome/browser/notifications/notification_platform_bridge_android.cc", "//chrome/browser/notifications/notification_platform_bridge_android.cc",
......
...@@ -2,6 +2,8 @@ ...@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD - style license that can be # Use of this source code is governed by a BSD - style license that can be
# found in the LICENSE file. # found in the LICENSE file.
import("//build/config/android/rules.gni")
source_set("services") { source_set("services") {
sources = [ sources = [
"long_screenshots_tab_service.cc", "long_screenshots_tab_service.cc",
...@@ -16,3 +18,7 @@ source_set("services") { ...@@ -16,3 +18,7 @@ source_set("services") {
"//components/paint_preview/common/mojom", "//components/paint_preview/common/mojom",
] ]
} }
java_cpp_enum("long_screenshots_tab_service_status_enum") {
sources = [ "long_screenshots_tab_service.h" ]
}
...@@ -38,12 +38,19 @@ class LongScreenshotsTabService ...@@ -38,12 +38,19 @@ class LongScreenshotsTabService
bool is_off_the_record); bool is_off_the_record);
~LongScreenshotsTabService() override; ~LongScreenshotsTabService() override;
// Define a list of statuses to describe the calling of paint preview and
// generation of the bitmap.
//
// A Java counterpart will be generated for this enum.
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.share.long_screenshots
enum Status { enum Status {
kOk = 0, kUnknown = 0,
kDirectoryCreationFailed = 1, kOk = 1,
kCaptureFailed = 2, kDirectoryCreationFailed = 2,
kProtoSerializationFailed = 3, kCaptureFailed = 3,
kWebContentsGone = 4, kProtoSerializationFailed = 4,
kWebContentsGone = 5,
kNativeServiceUninitialized = 6,
}; };
using FinishedCallback = base::OnceCallback<void(Status)>; using FinishedCallback = base::OnceCallback<void(Status)>;
......
...@@ -3496,7 +3496,6 @@ test("unit_tests") { ...@@ -3496,7 +3496,6 @@ test("unit_tests") {
"../browser/lite_video/lite_video_navigation_metrics_unittest.cc", "../browser/lite_video/lite_video_navigation_metrics_unittest.cc",
"../browser/lite_video/lite_video_user_blocklist_unittest.cc", "../browser/lite_video/lite_video_user_blocklist_unittest.cc",
"../browser/logging_chrome_unittest.cc", "../browser/logging_chrome_unittest.cc",
"../browser/long_screenshots/long_screenshots_tab_service_unittest.cc",
"../browser/media/history/media_history_keyed_service_unittest.cc", "../browser/media/history/media_history_keyed_service_unittest.cc",
"../browser/media/history/media_history_store_unittest.cc", "../browser/media/history/media_history_store_unittest.cc",
"../browser/media/media_engagement_contents_observer_unittest.cc", "../browser/media/media_engagement_contents_observer_unittest.cc",
...@@ -4152,7 +4151,6 @@ test("unit_tests") { ...@@ -4152,7 +4151,6 @@ test("unit_tests") {
"//chrome:child_dependencies", "//chrome:child_dependencies",
"//chrome:resources", "//chrome:resources",
"//chrome:strings", "//chrome:strings",
"//chrome/browser/long_screenshots:services",
"//chrome/browser/media/router:unittests", "//chrome/browser/media/router:unittests",
"//chrome/browser/notifications:unit_tests", "//chrome/browser/notifications:unit_tests",
"//chrome/browser/payments:unittests", "//chrome/browser/payments:unittests",
...@@ -4332,6 +4330,7 @@ test("unit_tests") { ...@@ -4332,6 +4330,7 @@ test("unit_tests") {
"../browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc", "../browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc",
"../browser/autofill/credit_card_accessory_controller_impl_unittest.cc", "../browser/autofill/credit_card_accessory_controller_impl_unittest.cc",
"../browser/autofill/manual_filling_controller_impl_unittest.cc", "../browser/autofill/manual_filling_controller_impl_unittest.cc",
"../browser/long_screenshots/long_screenshots_tab_service_unittest.cc",
"../browser/media/android/cdm/media_drm_origin_id_manager_unittest.cc", "../browser/media/android/cdm/media_drm_origin_id_manager_unittest.cc",
"../browser/metrics/chrome_android_metrics_provider_unittest.cc", "../browser/metrics/chrome_android_metrics_provider_unittest.cc",
"../browser/offline_pages/prefetch/notifications/prefetch_notification_service_impl_unittest.cc", "../browser/offline_pages/prefetch/notifications/prefetch_notification_service_impl_unittest.cc",
...@@ -4357,6 +4356,7 @@ test("unit_tests") { ...@@ -4357,6 +4356,7 @@ test("unit_tests") {
"//chrome:chrome_android_core", "//chrome:chrome_android_core",
"//chrome/android:app_hooks_java", "//chrome/android:app_hooks_java",
"//chrome/android:chrome_java", "//chrome/android:chrome_java",
"//chrome/browser/long_screenshots:services",
"//chrome/browser/optimization_guide/android:native_j_unittests_jni_headers", "//chrome/browser/optimization_guide/android:native_j_unittests_jni_headers",
"//chrome/browser/optimization_guide/android:native_java_unittests", "//chrome/browser/optimization_guide/android:native_java_unittests",
"//chrome/browser/password_check/android:unit_tests", "//chrome/browser/password_check/android:unit_tests",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment