Commit d01a2955 authored by Robbie McElrath's avatar Robbie McElrath Committed by Commit Bot

[AW] Add missing dependencies to //android_webview BUILD.gn files.

This CL almost makes gn check happy for all webview build targets. I
still need to move AwFeatureList to a common location since it's used
from multiple places.

Test: gn check out/aw '//android_webview/*'
Bug: 934152
Change-Id: I3635f36db8015db342350b0a50f0787d8c936bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828346Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Reviewed-by: default avatarvikas soni <vikassoni@chromium.org>
Reviewed-by: default avatarWill Harris <wfh@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701652}
parent 8ecac69b
...@@ -376,6 +376,8 @@ grit("generate_components_strings") { ...@@ -376,6 +376,8 @@ grit("generate_components_strings") {
source_set("webview_entry_point") { source_set("webview_entry_point") {
deps = [ deps = [
":common", ":common",
"//base",
"//weblayer:weblayer_lib",
] ]
sources = [ sources = [
"lib/webview_entry_point.cc", "lib/webview_entry_point.cc",
......
...@@ -62,13 +62,16 @@ source_set("gfx") { ...@@ -62,13 +62,16 @@ source_set("gfx") {
deps = [ deps = [
"//android_webview:browser_jni_headers", "//android_webview:browser_jni_headers",
"//android_webview/common",
"//base", "//base",
"//components/ui_devtools:buildflags", "//components/ui_devtools:buildflags",
"//components/viz/service", "//components/viz/service",
"//components/viz/service/main",
"//content/public/browser", "//content/public/browser",
"//gpu/command_buffer/client:gles2_implementation", "//gpu/command_buffer/client:gles2_implementation",
"//gpu/command_buffer/service", "//gpu/command_buffer/service",
"//gpu/ipc:gl_in_process_context", "//gpu/ipc:gl_in_process_context",
"//gpu/ipc/common:android_image_reader_utils",
"//gpu/ipc/common:common", "//gpu/ipc/common:common",
"//gpu/skia_bindings", "//gpu/skia_bindings",
"//gpu/vulkan:vulkan", "//gpu/vulkan:vulkan",
......
...@@ -49,9 +49,12 @@ source_set("renderer") { ...@@ -49,9 +49,12 @@ source_set("renderer") {
"//components/spellcheck:buildflags", "//components/spellcheck:buildflags",
"//components/spellcheck/renderer", "//components/spellcheck/renderer",
"//components/visitedlink/renderer", "//components/visitedlink/renderer",
"//content/public/child",
"//content/public/common",
"//content/public/renderer", "//content/public/renderer",
"//gin", "//gin",
"//third_party/blink/public:blink", "//third_party/blink/public:blink",
"//ui/base",
"//url", "//url",
"//v8", "//v8",
] ]
......
...@@ -349,7 +349,7 @@ source_set("webview_instrumentation_test_native_jni_impl") { ...@@ -349,7 +349,7 @@ source_set("webview_instrumentation_test_native_jni_impl") {
deps = [ deps = [
":webview_instrumentation_test_native_jni", ":webview_instrumentation_test_native_jni",
"//android_webview:common", "//android_webview/browser",
"//base", "//base",
"//base/test:test_support", "//base/test:test_support",
] ]
...@@ -360,8 +360,11 @@ test("android_webview_unittests") { ...@@ -360,8 +360,11 @@ test("android_webview_unittests") {
":android_webview_unittests_assets", ":android_webview_unittests_assets",
":android_webview_unittests_java", ":android_webview_unittests_java",
":android_webview_unittests_jni", ":android_webview_unittests_jni",
"//android_webview:common", "//android_webview/browser",
"//android_webview/browser/gfx",
"//base/test:test_support", "//base/test:test_support",
"//components/autofill/core/browser",
"//components/metrics",
"//components/prefs:prefs", "//components/prefs:prefs",
"//components/prefs:test_support", "//components/prefs:test_support",
"//content:content", "//content:content",
...@@ -369,6 +372,7 @@ test("android_webview_unittests") { ...@@ -369,6 +372,7 @@ test("android_webview_unittests") {
"//mojo/core/embedder", "//mojo/core/embedder",
"//net:net", "//net:net",
"//net:test_support", "//net:test_support",
"//services/network:test_support",
"//ui/base:ui_base_jni_headers", "//ui/base:ui_base_jni_headers",
"//ui/gl", "//ui/gl",
"//ui/gl:test_support", "//ui/gl:test_support",
......
...@@ -169,6 +169,7 @@ if (is_android) { ...@@ -169,6 +169,7 @@ if (is_android) {
"//ui/gl", "//ui/gl",
] ]
visibility = [ visibility = [
"//android_webview/browser/gfx",
"//gpu/*", "//gpu/*",
"//media/gpu:gpu", "//media/gpu:gpu",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment