Let setShouldDoFullPaintInvalidation accept reason

Combines setShouldDoFullPaintInvalidationWithReason() into
setShouldDoFullPaintInvalidation().

This is preparation to allow more paint invalidation reasons.

For now allow default value. In the future we may force every
setShouldDoFullPaintInvalidation to have a reason, when we can
remove the default value.

BUG=410465

Review URL: https://codereview.chromium.org/656643004

git-svn-id: svn://svn.chromium.org/blink/trunk@183700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/core/rendering/RenderObject.cpp

@@ -3046,7 +3046,7 @@ bool RenderObject::isRelayoutBoundaryForInspector() const
     return objectIsRelayoutBoundary(this);
 }
 
-void RenderObject::setShouldDoFullPaintInvalidationWithReason(PaintInvalidationReason reason)
+void RenderObject::setShouldDoFullPaintInvalidation(PaintInvalidationReason reason)
 {
     // Only full invalidation reasons are allowed.
     ASSERT(isFullPaintInvalidationReason(reason));
@@ -3054,7 +3054,7 @@ void RenderObject::setShouldDoFullPaintInvalidationWithReason(PaintInvalidationR
     // RenderText objects don't know how to invalidate paint for themselves, since they don't know how to compute their bounds.
     // Instead the parent fully invalidate when any text needs full paint invalidation.
     if (isText()) {
-        parent()->setShouldDoFullPaintInvalidationWithReason(reason);
+        parent()->setShouldDoFullPaintInvalidation(reason);
         return;
     }
 

third_party/WebKit/Source/core/rendering/RenderObject.h

@@ -996,8 +996,7 @@ public:
     void setPreviousPositionFromPaintInvalidationBacking(const LayoutPoint& positionFromPaintInvalidationBacking) { m_previousPositionFromPaintInvalidationBacking = positionFromPaintInvalidationBacking; }
 
     bool shouldDoFullPaintInvalidation() const { return m_bitfields.fullPaintInvalidationReason() != PaintInvalidationNone; }
-    void setShouldDoFullPaintInvalidation() { setShouldDoFullPaintInvalidationWithReason(PaintInvalidationFull); }
-    void setShouldDoFullPaintInvalidationWithReason(PaintInvalidationReason);
+    void setShouldDoFullPaintInvalidation(PaintInvalidationReason = PaintInvalidationFull);
     void clearShouldDoFullPaintInvalidation() { m_bitfields.setFullPaintInvalidationReason(PaintInvalidationNone); }
 
     bool shouldInvalidateOverflowForPaint() const { return m_bitfields.shouldInvalidateOverflowForPaint(); }

third_party/WebKit/Source/core/rendering/RenderObjectChildList.cpp

@@ -162,7 +162,7 @@ void RenderObjectChildList::insertChildNode(RenderObject* owner, RenderObject* n
     }
 
     newChild->setNeedsLayoutAndPrefWidthsRecalc();
-    newChild->setShouldDoFullPaintInvalidationWithReason(PaintInvalidationRendererInsertion);
+    newChild->setShouldDoFullPaintInvalidation(PaintInvalidationRendererInsertion);
     if (!owner->normalChildNeedsLayout())
         owner->setChildNeedsLayout(); // We may supply the static position for an absolute positioned child.