Commit d027680f authored by battre's avatar battre Committed by Commit bot

Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting...

Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (patchset #1 id:1 of https://codereview.chromium.org/892413007/)

Reason for revert:
Remove DumpWithoutCrashing() from URLRequestHttpJob again.

See crbug.com/432398 for stacktraces uncovered by this.

Original issue's description:
> DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback
>
> BUG=432398
>
> Committed: https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64
> Cr-Commit-Position: refs/heads/master@{#315052}

TBR=mmenke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=432398

Review URL: https://codereview.chromium.org/906223002

Cr-Commit-Position: refs/heads/master@{#315277}
parent d43704c7
......@@ -10,7 +10,6 @@
#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/debug/alias.h"
#include "base/debug/dump_without_crashing.h"
#include "base/file_version_info.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h"
......@@ -290,12 +289,6 @@ void URLRequestHttpJob::Start() {
}
void URLRequestHttpJob::Kill() {
if (awaiting_callback_) {
// TODO(battre) crbug.com/289715
// Simulate a crash to see who kills the job while it is waiting for a
// callback. This should not happen, see URLRequest::OrphanJob().
base::debug::DumpWithoutCrashing();
}
if (!transaction_.get())
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment