v8binding: Decouples DOMException code from DOMException implementation.

As a preparation to move DOMException's exception code into platform/,
this patch decouples the definition of exception code from the
implementation of DOMException class (especially data table).

Also makes the value of exception code match the legacy error code
of DOMException defined in Web IDL.

Bug: 849607
Change-Id: I3044c1ebac8ddb344b3c1d380a08482c57225b30
Reviewed-on: https://chromium-review.googlesource.com/1086955Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564823}

third_party/blink/public/mojom/quota/quota_types.mojom

@@ -12,12 +12,12 @@ enum StorageType {
   kUnknown,
 };
 
-// These values need to match dom/ExceptionState.h.
+// These values need to match core/dom/exception_code.h.
 enum QuotaStatusCode {
   kOk = 0,
-  kErrorNotSupported = 7,
-  kErrorInvalidModification = 11,
-  kErrorInvalidAccess = 13,
-  kErrorAbort = 17,
+  kErrorNotSupported = 9,          // NOT_SUPPORTED_ERR
+  kErrorInvalidModification = 13,  // INVALID_MODIFICATION_ERR
+  kErrorInvalidAccess = 15,        // INVALID_ACCESS_ERR
+  kErrorAbort = 20,                // ABORT_ERR
   kUnknown = -1,
 };

third_party/blink/public/platform/modules/indexeddb/web_idb_database_exception.h

@@ -34,13 +34,13 @@
 namespace blink {
 
 enum WebIDBDatabaseException {
-  kWebIDBDatabaseExceptionUnknownError = 23,
-  kWebIDBDatabaseExceptionConstraintError = 24,
-  kWebIDBDatabaseExceptionDataError = 25,
-  kWebIDBDatabaseExceptionVersionError = 28,
-  kWebIDBDatabaseExceptionAbortError = 17,
-  kWebIDBDatabaseExceptionQuotaError = 19,
-  kWebIDBDatabaseExceptionTimeoutError = 20,
+  kWebIDBDatabaseExceptionUnknownError = 28,
+  kWebIDBDatabaseExceptionConstraintError = 29,
+  kWebIDBDatabaseExceptionDataError = 30,
+  kWebIDBDatabaseExceptionVersionError = 33,
+  kWebIDBDatabaseExceptionAbortError = 20,
+  kWebIDBDatabaseExceptionQuotaError = 22,
+  kWebIDBDatabaseExceptionTimeoutError = 23,
 };
 
 }  // namespace blink

third_party/blink/renderer/core/dom/dom_exception.h

@@ -32,8 +32,6 @@
 #include "third_party/blink/renderer/core/core_export.h"
 #include "third_party/blink/renderer/core/dom/exception_code.h"
 #include "third_party/blink/renderer/platform/bindings/script_wrappable.h"
-#include "third_party/blink/renderer/platform/heap/handle.h"
-#include "third_party/blink/renderer/platform/wtf/forward.h"
 #include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
 
 namespace blink {
@@ -49,6 +47,9 @@ class CORE_EXPORT DOMException final : public ScriptWrappable {
   // Constructor exposed to script.
   static DOMException* Create(const String& message, const String& name);
 
+  static String GetErrorName(ExceptionCode);
+  static String GetErrorMessage(ExceptionCode);
+
   unsigned short code() const { return code_; }
   String name() const { return name_; }
 
@@ -64,9 +65,6 @@ class CORE_EXPORT DOMException final : public ScriptWrappable {
   }
   String ToStringForConsole() const;
 
-  static String GetErrorName(ExceptionCode);
-  static String GetErrorMessage(ExceptionCode);
-
  private:
   DOMException(unsigned short code,
                const String& name,

third_party/blink/renderer/core/dom/exception_code.h

@@ -24,73 +24,85 @@
 
 namespace blink {
 
-// This list must be in sync with |coreExceptions| in DOMExceptions.cpp.
-// Some of these are considered historical since they have been
-// changed or removed from the specifications.
+// DOMException's error code
+// https://heycam.github.io/webidl/#idl-DOMException-error-names
 enum {
-  kIndexSizeError = 1,
-  kHierarchyRequestError,
-  kWrongDocumentError,
-  kInvalidCharacterError,
-  kNoModificationAllowedError,
-  kNotFoundError,
-  kNotSupportedError,
-  kInUseAttributeError,  // Historical. Only used in setAttributeNode etc which
-                         // have been removed from the DOM specs.
-
-  // Introduced in DOM Level 2:
-  kInvalidStateError,
-  kSyntaxError,
-  kInvalidModificationError,
-  kNamespaceError,
-  kInvalidAccessError,
-
-  // Introduced in DOM Level 3:
-  kTypeMismatchError,  // Historical; use TypeError instead
-
-  // XMLHttpRequest extension:
-  kSecurityError,
-
-  // Others introduced in HTML5:
-  kNetworkError,
-  kAbortError,
-  kURLMismatchError,
-  kQuotaExceededError,
-  kTimeoutError,
-  kInvalidNodeTypeError,
-  kDataCloneError,
-
-  // The operation failed for an unknown transient reason (e.g. out of memory).
-  // Note: The error message is
-  // "An unknown error occurred within Indexed Database."
-  // (defined in third_party/blink/renderer/core/dom/dom_exception.cc)
-  // so, this code shouldn't be abused.
+  // DOMExceptions with the legacy error code.
+
+  // The minimum value of the legacy error code of DOMException defined in
+  // Web IDL.
+  // https://heycam.github.io/webidl/#idl-DOMException
+  kDOMExceptionLegacyCodeMin = 1,
+
+  kIndexSizeError = 1,  // Deprecated. Use ECMAScript RangeError instead.
+  // DOMStringSizeError (= 2) is deprecated and no longer supported.
+  kHierarchyRequestError = 3,
+  kWrongDocumentError = 4,
+  kInvalidCharacterError = 5,
+  // NoDataAllowedError (= 6) is deprecated and no longer supported.
+  kNoModificationAllowedError = 7,
+  kNotFoundError = 8,
+  kNotSupportedError = 9,
+  kInUseAttributeError = 10,  // Historical. Only used in setAttributeNode etc
+                              // which have been removed from the DOM specs.
+  kInvalidStateError = 11,
+  // Web IDL 2.7.1 Error names
+  // https://heycam.github.io/webidl/#idl-DOMException-error-names
+  // Note: Don't confuse the "SyntaxError" DOMException defined here with
+  // ECMAScript's SyntaxError. "SyntaxError" DOMException is used to report
+  // parsing errors in web APIs, for example when parsing selectors, while
+  // the ECMAScript SyntaxError is reserved for the ECMAScript parser.
+  kSyntaxError = 12,
+  kInvalidModificationError = 13,
+  kNamespaceError = 14,
+  // kInvalidAccessError is deprecated. Use ECMAScript TypeError for invalid
+  // arguments, |kNotSupportedError| for unsupported operations, and
+  // |kNotAllowedError| for denied requests instead.
+  kInvalidAccessError = 15,  // Deprecated.
+  // ValidationError (= 16) is deprecated and no longer supported.
+  kTypeMismatchError = 17,  // Deprecated. Use ECMAScript TypeError instead.
+  kSecurityError = 18,
+  kNetworkError = 19,
+  kAbortError = 20,
+  kURLMismatchError = 21,
+  kQuotaExceededError = 22,
+  kTimeoutError = 23,
+  kInvalidNodeTypeError = 24,
+  kDataCloneError = 25,
+
+  // The maximum value of the legacy error code of DOMException defined in
+  // Web IDL.
+  // https://heycam.github.io/webidl/#idl-DOMException
+  kDOMExceptionLegacyCodeMax = 25,
+
+  // DOMExceptions without the legacy error code.
+  kEncodingError,
+  kNotReadableError,
   kUnknownError,
-
-  // These are IDB-specific.
   kConstraintError,
   kDataError,
   kTransactionInactiveError,
   kReadOnlyError,
   kVersionError,
+  kOperationError,
+  kNotAllowedError,
 
-  // File system
-  kNotReadableError,
-  kEncodingError,
-  kPathExistsError,
-
-  // SQL
-  kSQLDatabaseError,  // Naming conflict with DatabaseError class.
+  // The rest of entries are defined out of scope of Web IDL.
 
-  // Web Crypto
-  kOperationError,
+  // DOMError (obsolete, not DOMException) defined in File system (obsolete).
+  // https://www.w3.org/TR/2012/WD-file-system-api-20120417/
+  kPathExistsError,
 
   // Push API
+  //
+  // PermissionDeniedError (obsolete) was replaced with NotAllowedError in the
+  // standard.
+  // https://github.com/WICG/BackgroundSync/issues/124
   kPermissionDeniedError,
 
-  kNotAllowedError,
-
   // Pointer Events
+  // https://w3c.github.io/pointerevents/
+  // Pointer Events introduced a new DOMException outside Web IDL.
   kInvalidPointerId,
 };