Commit d0388021 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

bindings: Remove a template argument from V8GlobalValueMap

V8GlobalValueMap had three arguments, and the third argument was
always v8::kNotWeak.  So, this CL removes the third argument.

Change-Id: I839be8160dcd1a45b74795f82d73a21d8c62851f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794366Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695095}
parent f2fcf852
...@@ -98,17 +98,16 @@ class V8GlobalValueMapTraits { ...@@ -98,17 +98,16 @@ class V8GlobalValueMapTraits {
* A map for safely storing persistent V8 values, based on * A map for safely storing persistent V8 values, based on
* v8::GlobalValueMap. * v8::GlobalValueMap.
*/ */
template <typename KeyType, template <typename KeyType, typename ValueType>
typename ValueType, class V8GlobalValueMap
v8::PersistentContainerCallbackType type> : public v8::GlobalValueMap<
class V8GlobalValueMap : public v8::GlobalValueMap< KeyType,
KeyType, ValueType,
ValueType, V8GlobalValueMapTraits<KeyType, ValueType, v8::kNotWeak>> {
V8GlobalValueMapTraits<KeyType, ValueType, type>> {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
typedef V8GlobalValueMapTraits<KeyType, ValueType, type> Traits; typedef V8GlobalValueMapTraits<KeyType, ValueType, v8::kNotWeak> Traits;
explicit V8GlobalValueMap(v8::Isolate* isolate) explicit V8GlobalValueMap(v8::Isolate* isolate)
: v8::GlobalValueMap<KeyType, ValueType, Traits>(isolate) {} : v8::GlobalValueMap<KeyType, ValueType, Traits>(isolate) {}
V8GlobalValueMap(v8::Isolate* isolate, const char* label) V8GlobalValueMap(v8::Isolate* isolate, const char* label)
......
...@@ -132,13 +132,9 @@ class PLATFORM_EXPORT V8PerContextData final { ...@@ -132,13 +132,9 @@ class PLATFORM_EXPORT V8PerContextData final {
// For each possible type of wrapper, we keep a boilerplate object. // For each possible type of wrapper, we keep a boilerplate object.
// The boilerplate is used to create additional wrappers of the same type. // The boilerplate is used to create additional wrappers of the same type.
typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Object, v8::kNotWeak> V8GlobalValueMap<const WrapperTypeInfo*, v8::Object> wrapper_boilerplates_;
WrapperBoilerplateMap;
WrapperBoilerplateMap wrapper_boilerplates_;
typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Function, v8::kNotWeak> V8GlobalValueMap<const WrapperTypeInfo*, v8::Function> constructor_map_;
ConstructorMap;
ConstructorMap constructor_map_;
std::unique_ptr<gin::ContextHolder> context_holder_; std::unique_ptr<gin::ContextHolder> context_holder_;
......
...@@ -262,7 +262,7 @@ class PLATFORM_EXPORT V8PerIsolateData { ...@@ -262,7 +262,7 @@ class PLATFORM_EXPORT V8PerIsolateData {
// When taking a V8 context snapshot, we can't keep V8 objects with eternal // When taking a V8 context snapshot, we can't keep V8 objects with eternal
// handles. So we use a special interface map that doesn't use eternal handles // handles. So we use a special interface map that doesn't use eternal handles
// instead of the default V8FunctionTemplateMap. // instead of the default V8FunctionTemplateMap.
V8GlobalValueMap<const WrapperTypeInfo*, v8::FunctionTemplate, v8::kNotWeak> V8GlobalValueMap<const WrapperTypeInfo*, v8::FunctionTemplate>
interface_template_map_for_v8_context_snapshot_; interface_template_map_for_v8_context_snapshot_;
std::unique_ptr<StringCache> string_cache_; std::unique_ptr<StringCache> string_cache_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment