Commit d0602298 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Enable "gn check" for //third_party/blink/common

- Remove non-existent source files
- Add missing dependencies
- Move browser_interface_broker_proxy.h and
  thread_safe_browser_interface_broker_proxy.h from public:blink_headers
  to public/common:headers
  These files are included by common:common, however we can't add
  public:blink_headers to common:common's deps because of a circular
  dependency.

This CL has no behavior changes.

Bug: 800764
Change-Id: I61cc0c08978ed0594cb0a0f7b395721978a36a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434009
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811102}
parent d1553ad3
......@@ -196,7 +196,6 @@ no_check_targets = [
"//sandbox/win:*", # 7 errors
# //third_party/blink/*, https://crbug.com/800764
"//third_party/blink/common:*", # 9 errors
"//third_party/blink/renderer/core/accessibility:*", # 27 errors
"//third_party/blink/renderer/core/animation:*", # 506 errors
"//third_party/blink/renderer/core/animation_frame:*", # 4 errors
......
......@@ -71,8 +71,6 @@ source_set("common") {
"associated_interfaces/associated_interface_registry.cc",
"blob/blob_utils.cc",
"bluetooth/web_bluetooth_device_id.cc",
"bluetooth/web_bluetooth_device_id.h",
"bluetooth/web_bluetooth_device_id_mojom_traits.h",
"browser_interface_broker_proxy.cc",
"cache_storage/cache_storage_utils.cc",
"client_hints/client_hints.cc",
......@@ -183,7 +181,9 @@ source_set("common") {
"//services/metrics/public/cpp:ukm_builders",
"//services/metrics/public/mojom:mojom",
"//services/network/public/cpp:cpp",
"//ui/base:base",
"//ui/events:events_base",
"//ui/latency/mojom:shared_mojom_traits",
]
# iOS doesn't use and must not depend on //media
......@@ -264,8 +264,11 @@ source_set("common_unittests_sources") {
deps = [
"//base",
"//base/test:test_support",
"//media/capture:capture_base",
"//mojo/core/embedder",
"//mojo/public/cpp/test_support:test_utils",
"//net",
"//net:test_support",
"//services/device:test_support",
"//services/network:test_support",
"//skia/public/mojom",
......
......@@ -118,8 +118,6 @@ source_set("test_headers") {
# the browser- and renderer-side components.
source_set("blink_headers") {
sources = [
"common/browser_interface_broker_proxy.h",
"common/thread_safe_browser_interface_broker_proxy.h",
"platform/audio/web_audio_device_source_type.h",
"platform/blame_context.h",
"platform/cross_variant_mojo_util.h",
......
......@@ -60,6 +60,7 @@ source_set("headers") {
"blob/blob_utils.h",
"bluetooth/web_bluetooth_device_id.h",
"bluetooth/web_bluetooth_device_id_mojom_traits.h",
"browser_interface_broker_proxy.h",
"cache_storage/cache_storage_utils.h",
"client_hints/client_hints.h",
"context_menu_data/edit_flags.h",
......@@ -174,6 +175,7 @@ source_set("headers") {
"sms/sms_receiver_destroyed_reason.h",
"sms/sms_receiver_outcome.h",
"switches.h",
"thread_safe_browser_interface_broker_proxy.h",
"tokens/multi_token.h",
"tokens/multi_token_internal.h",
"tokens/token_mojom_traits_helper.h",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment