Commit d076b1b7 authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Remove Language preferences from incognito whitelist.

Language preferences are removed from the persistent storage list for
incognito mode.
After this CL, if this preference is changed from incognito mode,
it is only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia013aaf468aa29b2efcfcb670003f09535e2a060
Reviewed-on: https://chromium-review.googlesource.com/1174118Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584379}
parent 0489ac9f
......@@ -15,7 +15,6 @@
#include "components/flags_ui/flags_ui_pref_names.h"
#include "components/google/core/browser/google_pref_names.h"
#include "components/invalidation/impl/invalidation_prefs.h"
#include "components/language/core/browser/pref_names.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/omnibox/browser/omnibox_pref_names.h"
#include "components/onc/onc_pref_names.h"
......@@ -223,14 +222,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
prefs::kResolveTimezoneByGeolocation,
prefs::kResolveTimezoneByGeolocationMethod,
prefs::kResolveTimezoneByGeolocationMigratedToMethod,
prefs::kLanguageCurrentInputMethod, prefs::kLanguagePreviousInputMethod,
prefs::kLanguageAllowedInputMethods, prefs::kLanguagePreferredLanguages,
prefs::kLanguagePreferredLanguagesSyncable, prefs::kLanguagePreloadEngines,
prefs::kLanguagePreloadEnginesSyncable, prefs::kLanguageEnabledImes,
prefs::kLanguageEnabledImesSyncable, prefs::kLanguageImeMenuActivated,
prefs::kLanguageShouldMergeInputMethods, prefs::kLanguageSendFunctionKeys,
prefs::kLanguageXkbAutoRepeatEnabled, prefs::kLanguageXkbAutoRepeatDelay,
prefs::kLanguageXkbAutoRepeatInterval,
prefs::kLabsAdvancedFilesystemEnabled, prefs::kLabsMediaplayerEnabled,
prefs::kShow3gPromoNotification, prefs::kDataSaverPromptsShown,
......@@ -671,9 +662,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
invalidation::prefs::kInvalidatorSavedInvalidations,
invalidation::prefs::kInvalidationServiceUseGCMChannel,
// components/language/core/browser/pref_names.h
language::prefs::kApplicationLocale, language::prefs::kUserLanguageProfile,
// components/omnibox/browser/omnibox_pref_names.h
omnibox::kZeroSuggestCachedResults,
......@@ -700,7 +688,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
// TODO(https://crbug.com/861722): Check with code owners why this pref is
// required in tests, if possible, update tests and remove.
chromeos::extension_ime_util::kBrailleImeEngineId,
chromeos::extension_ime_util::kArcImeLanguage,
#endif // defined(OS_CHROMEOS)
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment