Change pointer type of WebLocalFrameImpl from raw pointers to RefPtrWillBePersistent

in WebEmbeddedWorkerImpl and WebSharedWorkerImpl.


Those member variables are instantiated with WebLocalFrame::create(),
and it actually creates a WebLocalFrameImpl instance.

On Oilpan build, WebLocalFrameImpl has a self-referential persistent to
keep itself alive, and it will be cleared on call of
WebLocalFrameImpl::close().

In those two classes, m_mainFrame->close() is called in destructors, so
the self referential persistent is cleared in destruction on Oilpan build.
Beside it, on both non-Oilpan build and Oilpan build, m_mainFrame is
also cleared and should be released.


BUG=509911

Review URL: https://codereview.chromium.org/1308313002

git-svn-id: svn://svn.chromium.org/blink/trunk@201191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -84,8 +84,8 @@ WebEmbeddedWorkerImpl::WebEmbeddedWorkerImpl(PassOwnPtr<WebServiceWorkerContextC
     : m_workerContextClient(client)
     , m_contentSettingsClient(ContentSettingsClient)
     , m_workerInspectorProxy(WorkerInspectorProxy::create())
-    , m_webView(0)
-    , m_mainFrame(0)
+    , m_webView(nullptr)
+    , m_mainFrame(nullptr)
     , m_loadingShadowPage(false)
     , m_askedToTerminate(false)
     , m_waitingForDebuggerState(NotWaitingForDebugger)
@@ -219,7 +219,7 @@ void WebEmbeddedWorkerImpl::prepareShadowPageForLoader()
     settings->setAllowDisplayOfInsecureContent(false);
     settings->setAllowRunningOfInsecureContent(false);
     m_mainFrame = toWebLocalFrameImpl(WebLocalFrame::create(WebTreeScopeType::Document, this));
-    m_webView->setMainFrame(m_mainFrame);
+    m_webView->setMainFrame(m_mainFrame.get());
     m_mainFrame->setDevToolsAgentClient(this);
 
     // If we were asked to wait for debugger then it is the good time to do that.

third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

@@ -115,7 +115,7 @@ private:
     // deref'ed) when this EmbeddedWorkerImpl is destructed, therefore they
     // are guaranteed to exist while this object is around.
     WebView* m_webView;
-    WebLocalFrameImpl* m_mainFrame;
+    RefPtrWillBePersistent<WebLocalFrameImpl> m_mainFrame;
 
     bool m_loadingShadowPage;
     bool m_askedToTerminate;

third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

@@ -81,8 +81,8 @@ namespace blink {
 // possible.
 
 WebSharedWorkerImpl::WebSharedWorkerImpl(WebSharedWorkerClient* client)
-    : m_webView(0)
-    , m_mainFrame(0)
+    : m_webView(nullptr)
+    , m_mainFrame(nullptr)
     , m_askedToTerminate(false)
     , m_workerInspectorProxy(WorkerInspectorProxy::create())
     , m_client(client)
@@ -133,7 +133,7 @@ void WebSharedWorkerImpl::initializeLoader()
     // FIXME: Settings information should be passed to the Worker process from Browser process when the worker
     // is created (similar to RenderThread::OnCreateNewView).
     m_mainFrame = toWebLocalFrameImpl(WebLocalFrame::create(WebTreeScopeType::Document, this));
-    m_webView->setMainFrame(m_mainFrame);
+    m_webView->setMainFrame(m_mainFrame.get());
     m_mainFrame->setDevToolsAgentClient(this);
 
     // If we were asked to pause worker context on start and wait for debugger then it is the good time to do that.

third_party/WebKit/Source/web/WebSharedWorkerImpl.h

@@ -137,7 +137,7 @@ private:
     // 'shadow page' - created to proxy loading requests from the worker.
     RefPtrWillBePersistent<ExecutionContext> m_loadingDocument;
     WebView* m_webView;
-    WebLocalFrameImpl* m_mainFrame;
+    RefPtrWillBePersistent<WebLocalFrameImpl> m_mainFrame;
     bool m_askedToTerminate;
 
     // This one is bound to and used only on the main thread.