[LayoutNG] Fix margins for orthogonal atomic inlines

When computing margins for orthogonal atomic inlines, the old
code was using the writing-mode of the atomic inline to
determine whether to flip line or not.

This patch fixes to use the constraint space's writing-mode.

For other computation than flipped-lines,
ComputeMarginsForVisualContainer already uses the writing-
mode of the constraint space.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I85d12a29cf5e845d3fef00b9832c68d106e80dca
Reviewed-on: https://chromium-review.googlesource.com/1179519
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584028}

third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

@@ -489,13 +489,6 @@ crbug.com/591099 fast/borders/inline-mask-overlay-image-outset-vertical-rl.html
 crbug.com/591099 fast/box-sizing/replaced.html [ Failure ]
 crbug.com/591099 fast/css-generated-content/first-letter-next-sibling-crash.html [ Crash ]
 crbug.com/591099 fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html [ Crash ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-horiz-02.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-horiz-03.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-horiz-04.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-horiz-05.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html [ Failure ]
-crbug.com/591099 fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html [ Failure ]
 crbug.com/591099 fast/css-grid-layout/maximize-tracks-definite-indefinite-width.html [ Failure ]
 crbug.com/591099 fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html [ Failure ]
 crbug.com/591099 fast/css-intrinsic-dimensions/height-positioned.html [ Failure ]

third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc

@@ -785,9 +785,9 @@ void NGLineBreaker::HandleAtomicInline(const NGInlineItem& item) {
   DCHECK(item.Style());
   const ComputedStyle& style = *item.Style();
   bool is_flipped_lines = style.IsFlippedLinesWritingMode();
-  item_result->margins =
-      NGLineBoxStrut(ComputeMarginsForVisualContainer(constraint_space_, style),
-                     is_flipped_lines);
+  item_result->margins = NGLineBoxStrut(
+      ComputeMarginsForVisualContainer(constraint_space_, style),
+      IsFlippedLinesWritingMode(constraint_space_.GetWritingMode()));
   item_result->padding = NGLineBoxStrut(
       ComputePadding(constraint_space_, style), is_flipped_lines);
   item_result->inline_size += item_result->margins.InlineSum();