Commit d0cafb0d authored by Theresa Wellington's avatar Theresa Wellington Committed by Commit Bot

Re-enable NewTabPageTest#testFocusFakebox on phones

This test was only failing on tablets, so conditionally disable to
retain some coverage.

TBR=jinsukkim@chromium.org

Bug: 1145195
Change-Id: I12cd015f6c370b177402b6f2f30d00f22dda362a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522903Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825079}
parent 46441ad8
...@@ -42,6 +42,7 @@ import org.chromium.base.test.util.CallbackHelper; ...@@ -42,6 +42,7 @@ import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Criteria; import org.chromium.base.test.util.Criteria;
import org.chromium.base.test.util.CriteriaHelper; import org.chromium.base.test.util.CriteriaHelper;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest; import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest; import org.chromium.base.test.util.FlakyTest;
...@@ -74,6 +75,7 @@ import org.chromium.content_public.browser.test.util.TouchCommon; ...@@ -74,6 +75,7 @@ import org.chromium.content_public.browser.test.util.TouchCommon;
import org.chromium.net.test.EmbeddedTestServer; import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.net.test.util.TestWebServer; import org.chromium.net.test.util.TestWebServer;
import org.chromium.ui.base.PageTransition; import org.chromium.ui.base.PageTransition;
import org.chromium.ui.test.util.UiDisableIf;
import java.io.IOException; import java.io.IOException;
import java.lang.ref.WeakReference; import java.lang.ref.WeakReference;
...@@ -213,7 +215,7 @@ public class NewTabPageTest { ...@@ -213,7 +215,7 @@ public class NewTabPageTest {
*/ */
@Test @Test
@SmallTest @SmallTest
@DisabledTest(message = "https://crbug.com/1145195") @DisableIf.Device(type = {UiDisableIf.TABLET}) // https://crbug.com/1145195
@Feature({"NewTabPage", "FeedNewTabPage"}) @Feature({"NewTabPage", "FeedNewTabPage"})
public void testFocusFakebox() { public void testFocusFakebox() {
int initialFakeboxTop = getFakeboxTop(mNtp); int initialFakeboxTop = getFakeboxTop(mNtp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment