Skip to content

GitLab

T
tangled
Commit d0d418bc authored by Kunihiko Sakamoto's avatar Kunihiko Sakamoto Committed by Commit Bot
Browse files
Options

Deflake http/tests/preload/meta-viewport-link-headers.html 

The test was flaky because internals.settings.setViewportMetaEnabled()
for the child window was called too early, before the initial settings
are applied to the new window.

Bug: 613887
Change-Id: I8222e616ce1489671dc9ea43724ad3a1ad70f91d
Reviewed-on: https://chromium-review.googlesource.com/c/1356175Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarYoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613404}
parent 37f67ef4
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 7 deletions
third_party/blink/web_tests/TestExpectations
View file @ d0d418bc
...@@ -2343,8 +2343,6 @@ crbug.com/555703 [ Mac ] virtual/media-gpu-accelerated/ [ Skip ] ...@@ -2343,8 +2343,6 @@ crbug.com/555703 [ Mac ] virtual/media-gpu-accelerated/ [ Skip ]
crbug.com/555703 [ Win ] virtual/media-gpu-accelerated/ [ Skip ] crbug.com/555703 [ Win ] virtual/media-gpu-accelerated/ [ Skip ]
crbug.com/555703 [ Fuchsia ] virtual/media-gpu-accelerated/ [ Skip ] crbug.com/555703 [ Fuchsia ] virtual/media-gpu-accelerated/ [ Skip ]
crbug.com/613887 http/tests/preload/meta-viewport-link-headers.html [ Failure Pass ]
crbug.com/467477 fast/multicol/vertical-rl/nested-columns.html [ Failure ] crbug.com/467477 fast/multicol/vertical-rl/nested-columns.html [ Failure ]
crbug.com/674225 [ Mac ] fast/replaced/input-radio-height-inside-auto-container.html [ Failure ] crbug.com/674225 [ Mac ] fast/replaced/input-radio-height-inside-auto-container.html [ Failure ]
......
third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers.html
View file @ d0d418bc
...@@ -21,9 +21,5 @@ ...@@ -21,9 +21,5 @@
assert_unreached("FAIL: small resource was not loaded"); assert_unreached("FAIL: small resource was not loaded");
t.done(); t.done();
}, false)); }, false));
var w = window.open("resources/media-link-headers.php"); var w = window.open("resources/enable-viewport-and-refresh.html?media-link-headers.php");
if (w.internals) {
w.internals.settings.setViewportEnabled(true);
w.internals.settings.setViewportMetaEnabled(true);
}
</script> </script>
third_party/blink/web_tests/http/tests/preload/resources/enable-viewport-and-refresh.html 0 → 100644
View file @ d0d418bc
<!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setViewportEnabled(true);
internals.settings.setViewportMetaEnabled(true);
}
location.href = location.search.substr(1);
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment