Don't paint outline in composited foreground layer

Previously when there is composited foreground layer, the outline was painted on both the main graphics layer and the foreground layer. Change-Id: I9c0bcf14ce4acb1f41a732e480b9c1a4126f69bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466620Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816669}

Don't paint outline in composited foreground layer
Previously when there is composited foreground layer, the outline was painted on both the main graphics layer and the foreground layer. Change-Id: I9c0bcf14ce4acb1f41a732e480b9c1a4126f69bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466620Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816669}
d0fda0f7 · Xianzhu Wang · Commit Bot · 60d189c7 · d0fda0f7 · d0fda0f7
Commit d0fda0f7 authored Oct 13, 2020 by Xianzhu Wang Committed by Commit Bot Oct 13, 2020
3 changed files
--- a/third_party/blink/renderer/core/paint/paint_layer_painter.cc
+++ b/third_party/blink/renderer/core/paint/paint_layer_painter.cc
@@ -374,8 +374,7 @@ PaintResult PaintLayerPainter::PaintLayerContents(
  // is not scrolled and should be above scrolled content.
  bool should_paint_self_outline =
      is_self_painting_layer && !is_painting_overlay_overflow_controls &&
-      (is_painting_composited_decoration ||
-       (!is_painting_overflow_contents && !is_painting_mask)) &&
+      is_painting_composited_decoration &&
      paint_layer_.GetLayoutObject().StyleRef().HasOutline();

  PhysicalOffset subpixel_accumulation =

--- a/third_party/blink/web_tests/external/wpt/css/css-ui/translucent-outline-ref.html
+++ b/third_party/blink/web_tests/external/wpt/css/css-ui/translucent-outline-ref.html
+<!DOCTYPE html>
+There should be a square in uniform pale green color.
+<div style="width: 100px; height: 100px; background: rgba(0, 128, 0, 0.5)"></div>
--- a/third_party/blink/web_tests/external/wpt/css/css-ui/translucent-outline.html
+++ b/third_party/blink/web_tests/external/wpt/css/css-ui/translucent-outline.html
+<!DOCTYPE html>
+<title>Outline with translucent color, will-change:transform and negative-z index child</title>
+<link rel="help" title="7.1. 'outline' property" href="http://www.w3.org/TR/css3-ui/#outline">
+<link rel="match" href="translucent-outline-ref.html">
+<style>div { will-change: transform; }</style>
+There should be a square in uniform pale green color.
+<div style="position: relative; top: 25px; left: 25px;
+            width: 50px; height: 50px;
+            outline: 25px solid rgba(0, 128, 0, 0.5);
+            background: rgba(0, 128, 0, 0.5)">
+  <div style="position: absolute; width: 10px; height: 10px; z-index: -1"></div>
+</div>