Commit d1063c1e authored by Wenyu Fu's avatar Wenyu Fu Committed by Commit Bot

Adjust layout for large promo card variation

Add paddingTop to make spacing consistent between top and bottom.

Bug: 1068831, 1084791
Change-Id: I68639415615c24d3fa7889c53b74d9102482a59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209895Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770929}
parent 2ca08ce3
5e25740fc055825e7c6af739ae21fd461459476f 81b1ac98f141b5a7c07b03c466b60ce06f84d299
\ No newline at end of file \ No newline at end of file
4de8e638c09b68f2d4cc36eeea5852c512c7bd3c 924aebba853a13a719f0ec4082f48a839d8601c8
\ No newline at end of file \ No newline at end of file
c7efa7d748f33445b05a50818effb1f69c55ae2e 90f145e66f786473cf0e97857a281a27008fd79c
\ No newline at end of file \ No newline at end of file
59860707c8b43e47e19978e4666c190a85294421 f08ce76ecdd54952ce5a1656313c054bc0d1f114
\ No newline at end of file \ No newline at end of file
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
android:gravity="center_horizontal" android:gravity="center_horizontal"
android:orientation="vertical" android:orientation="vertical"
android:background="@drawable/hairline_border_card_background" android:background="@drawable/hairline_border_card_background"
android:paddingTop="1dp"> android:paddingVertical="@dimen/promo_large_padding_vertical">
<!-- Promo Illustration--> <!-- Promo Illustration-->
<ImageView <ImageView
...@@ -29,8 +29,7 @@ ...@@ -29,8 +29,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:orientation="vertical" android:orientation="vertical"
android:paddingHorizontal="@dimen/promo_large_padding_horizontal" android:paddingHorizontal="@dimen/promo_large_padding_horizontal">
android:paddingBottom="@dimen/promo_large_padding_bottom">
<org.chromium.ui.widget.TextViewWithLeading <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/promo_title" android:id="@+id/promo_title"
......
...@@ -74,7 +74,7 @@ ...@@ -74,7 +74,7 @@
<dimen name="promo_slim_button_max_width">84dp</dimen> <dimen name="promo_slim_button_max_width">84dp</dimen>
<dimen name="promo_slim_padding_vertical">10dp</dimen> <dimen name="promo_slim_padding_vertical">10dp</dimen>
<dimen name="promo_large_padding_bottom">8dp</dimen> <dimen name="promo_large_padding_vertical">8dp</dimen>
<dimen name="promo_large_padding_horizontal">24dp</dimen> <dimen name="promo_large_padding_horizontal">24dp</dimen>
<dimen name="promo_large_illustration_margin_bottom">16dp</dimen> <dimen name="promo_large_illustration_margin_bottom">16dp</dimen>
<dimen name="promo_large_text_group_bottom_margin">10dp</dimen> <dimen name="promo_large_text_group_bottom_margin">10dp</dimen>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment