Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344

Review URL: https://codereview.chromium.org/1625763002

Cr-Commit-Position: refs/heads/master@{#371402}

third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -40,8 +40,7 @@ namespace blink {
 
 class LayoutPoint;
 
-// TODO(yosin) We should use capitalized name instead of |SEL_DEFAULT_AFFINITY|.
-const TextAffinity SEL_DEFAULT_AFFINITY = TextAffinity::Downstream; // NOLINT
+const TextAffinity SelDefaultAffinity = TextAffinity::Downstream;
 enum SelectionDirection { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft };
 
 // Listener of |VisibleSelection| modification. |didChangeVisibleSelection()|
@@ -66,8 +65,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
 public:
     VisibleSelectionTemplate();
     VisibleSelectionTemplate(const PositionTemplate<Strategy>&, TextAffinity, bool isDirectional = false);
-    VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false);
-    explicit VisibleSelectionTemplate(const EphemeralRangeTemplate<Strategy>&, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false);
+    VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SelDefaultAffinity, bool isDirectional = false);
+    explicit VisibleSelectionTemplate(const EphemeralRangeTemplate<Strategy>&, TextAffinity = SelDefaultAffinity, bool isDirectional = false);
 
     explicit VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, bool isDirectional = false);
     VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, const VisiblePositionTemplate<Strategy>&, bool isDirectional = false);

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -1384,9 +1384,9 @@ void ReplaceSelectionCommand::completeHTMLReplacement(const Position &lastPositi
     m_endOfInsertedRange = end;
 
     if (m_selectReplacement)
-        setEndingSelection(VisibleSelection(start, end, SEL_DEFAULT_AFFINITY, endingSelection().isDirectional()));
+        setEndingSelection(VisibleSelection(start, end, SelDefaultAffinity, endingSelection().isDirectional()));
     else
-        setEndingSelection(VisibleSelection(end, SEL_DEFAULT_AFFINITY, endingSelection().isDirectional()));
+        setEndingSelection(VisibleSelection(end, SelDefaultAffinity, endingSelection().isDirectional()));
 }
 
 void ReplaceSelectionCommand::mergeTextNodesAroundPosition(Position& position, Position& positionOnlyToBeUpdated)

third_party/WebKit/Source/core/page/EventSource.h

@@ -63,10 +63,11 @@ public:
     String url() const;
     bool withCredentials() const;
 
-    typedef short State;
-    static const State CONNECTING = 0;
-    static const State OPEN = 1;
-    static const State CLOSED = 2;
+    enum State : unsigned short {
+        CONNECTING = 0,
+        OPEN = 1,
+        CLOSED = 2
+    };
 
     State readyState() const;
 

third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp

@@ -78,7 +78,7 @@ namespace blink {
 typedef double Vector4[4];
 typedef double Vector3[3];
 
-const double SMALL_NUMBER = 1.e-8;
+const double SmallNumber = 1.e-8;
 
 // inverse(original_matrix, inverse_matrix)
 //
@@ -220,7 +220,7 @@ static bool inverse(const TransformationMatrix::Matrix4& matrix, TransformationM
     // then the inverse matrix is not unique.
     double det = determinant4x4(matrix);
 
-    if (fabs(det) < SMALL_NUMBER)
+    if (fabs(det) < SmallNumber)
         return false;
 
 #if CPU(ARM64)
@@ -1449,7 +1449,7 @@ bool TransformationMatrix::isInvertible() const
 
     double det = blink::determinant4x4(m_matrix);
 
-    if (fabs(det) < SMALL_NUMBER)
+    if (fabs(det) < SmallNumber)
         return false;
 
     return true;

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -427,7 +427,7 @@ void WebFrameWidgetImpl::setFocus(bool enable)
                     // instead. Note that this has the side effect of moving the
                     // caret back to the beginning of the text.
                     Position position(element, 0);
-                    focusedFrame->selection().setSelection(VisibleSelection(position, SEL_DEFAULT_AFFINITY));
+                    focusedFrame->selection().setSelection(VisibleSelection(position, SelDefaultAffinity));
                 }
             }
         }

third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2295,7 +2295,7 @@ void WebViewImpl::setFocus(bool enable)
                     // instead. Note that this has the side effect of moving the
                     // caret back to the beginning of the text.
                     Position position(element, 0);
-                    focusedFrame->selection().setSelection(VisibleSelection(position, SEL_DEFAULT_AFFINITY));
+                    focusedFrame->selection().setSelection(VisibleSelection(position, SelDefaultAffinity));
                 }
             }
         }