Skip to content

GitLab

T
tangled
Commit d1615ffa authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot
Browse files
Options

[PE] Fix repeating table header/footer printing when page is scrolled 

Bug: 854848
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb
Reviewed-on: https://chromium-review.googlesource.com/1109500Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569420}
parent b92a836e
Hide whitespace changes
Inline Side-by-side
Showing with 250 additions and 0 deletions
third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled-expected.html 0 → 100644
View file @ d1615ffa
<!DOCTYPE html>
<style>
body {
font-size: 30px;
line-height: 50px;
}
</style>
<script>
onload = function() {
if (window.testRunner)
testRunner.setPrinting();
};
</script>
<table>
<thead>
<tr>
<th>Header</th>
</tr>
</thead>
<tbody>
<tr>
<td>1</td>
</tr>
<tr>
<td>2</td>
</tr>
<tr>
<td>3</td>
</tr>
<tr>
<td>4</td>
</tr>
<tr>
<td>5</td>
</tr>
<tr>
<td>6</td>
</tr>
<tr>
<td>7</td>
</tr>
<tr>
<td>8</td>
</tr>
<tr>
<td>9</td>
</tr>
<tr>
<td>10</td>
</tr>
<tr>
<td>11</td>
</tr>
<tr>
<td>12</td>
</tr>
<tr>
<td>13</td>
</tr>
<tr>
<td>14</td>
</tr>
<tr>
<td>15</td>
</tr>
<tr>
<td>16</td>
</tr>
<tr>
<td>17</td>
</tr>
<tr>
<td>18</td>
</tr>
<tr>
<td>19</td>
</tr>
<tr>
<td>20</td>
</tr>
<tr>
<td>21</td>
</tr>
<tr>
<td>22</td>
</tr>
<tr>
<td>23</td>
</tr>
<tr>
<td>24</td>
</tr>
<tr>
<td>25</td>
</tr>
<tr>
<td>26</td>
</tr>
<tr>
<td>27</td>
</tr>
<tr>
<td>28</td>
</tr>
<tr>
<td>29</td>
</tr>
<tr>
<td>30</td>
</tr>
<tr>
<td>31</td>
</tr>
<tr>
<td>32</td>
</tr>
</tbody>
<tfoot>
<tr>
<th>Footer</th>
</tr>
</tfoot>
</table>
third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled.html 0 → 100644
View file @ d1615ffa
<!DOCTYPE html>
<style>
body {
font-size: 30px;
line-height: 50px;
}
</style>
<script>
onload = function() {
window.scrollBy(0, 400);
if (window.testRunner)
testRunner.setPrinting();
};
</script>
<table>
<thead>
<tr>
<th>Header</th>
</tr>
</thead>
<tbody>
<tr>
<td>1</td>
</tr>
<tr>
<td>2</td>
</tr>
<tr>
<td>3</td>
</tr>
<tr>
<td>4</td>
</tr>
<tr>
<td>5</td>
</tr>
<tr>
<td>6</td>
</tr>
<tr>
<td>7</td>
</tr>
<tr>
<td>8</td>
</tr>
<tr>
<td>9</td>
</tr>
<tr>
<td>10</td>
</tr>
<tr>
<td>11</td>
</tr>
<tr>
<td>12</td>
</tr>
<tr>
<td>13</td>
</tr>
<tr>
<td>14</td>
</tr>
<tr>
<td>15</td>
</tr>
<tr>
<td>16</td>
</tr>
<tr>
<td>17</td>
</tr>
<tr>
<td>18</td>
</tr>
<tr>
<td>19</td>
</tr>
<tr>
<td>20</td>
</tr>
<tr>
<td>21</td>
</tr>
<tr>
<td>22</td>
</tr>
<tr>
<td>23</td>
</tr>
<tr>
<td>24</td>
</tr>
<tr>
<td>25</td>
</tr>
<tr>
<td>26</td>
</tr>
<tr>
<td>27</td>
</tr>
<tr>
<td>28</td>
</tr>
<tr>
<td>29</td>
</tr>
<tr>
<td>30</td>
</tr>
<tr>
<td>31</td>
</tr>
<tr>
<td>32</td>
</tr>
</tbody>
<tfoot>
<tr>
<th>Footer</th>
</tr>
</tfoot>
</table>
third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
View file @ d1615ffa
...@@ -2281,6 +2281,9 @@ void PaintPropertyTreeBuilder:: ...@@ -2281,6 +2281,9 @@ void PaintPropertyTreeBuilder::
LayoutView* view = object_.View(); LayoutView* view = object_.View();
context_.repeating_table_section_bounding_box = context_.repeating_table_section_bounding_box =
BoundingBoxInPaginationContainer(object_, *view->Layer()); BoundingBoxInPaginationContainer(object_, *view->Layer());
// Convert the bounding box into the scrolling contents space.
context_.repeating_table_section_bounding_box.Move(LayoutUnit(),
view->ScrollTop());
auto page_height = view->PageLogicalHeight(); auto page_height = view->PageLogicalHeight();
const auto& bounding_box = context_.repeating_table_section_bounding_box; const auto& bounding_box = context_.repeating_table_section_bounding_box;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment