Commit d16ee02e authored by Dave Tapuska's avatar Dave Tapuska Committed by Commit Bot

Allow testdriver-vendor.js to send more than one key

maxlength-number.html sends multiple keys in one call. Iterate across
the keys string to send more than one character.

Move another test that uses the actions API to the unsupported section.

Reland 39760144 without the pause.html
expectation removed.

Change-Id: I9cb0a2f68a5792615c711d59e29dbca9830e2f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133872
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarRobert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755962}
parent 63392c95
...@@ -2869,6 +2869,7 @@ crbug.com/1015331 external/wpt/css/css-text/white-space/eol-spaces-bidi-001.html ...@@ -2869,6 +2869,7 @@ crbug.com/1015331 external/wpt/css/css-text/white-space/eol-spaces-bidi-001.html
# needs implementation of test_driver_internal.action_sequence # needs implementation of test_driver_internal.action_sequence
crbug.com/893480 external/wpt/editing/run/caretnavigation.html [ Timeout ] crbug.com/893480 external/wpt/editing/run/caretnavigation.html [ Timeout ]
crbug.com/893480 external/wpt/input-events/input-events-typing.html [ Timeout ] crbug.com/893480 external/wpt/input-events/input-events-typing.html [ Timeout ]
crbug.com/893480 external/wpt/infrastructure/testdriver/actions/eventOrder.html [ Timeout ]
crbug.com/893480 external/wpt/infrastructure/testdriver/actions/elementTiming.html [ Timeout ] crbug.com/893480 external/wpt/infrastructure/testdriver/actions/elementTiming.html [ Timeout ]
crbug.com/893480 external/wpt/infrastructure/testdriver/actions/multiDevice.html [ Failure Timeout ] crbug.com/893480 external/wpt/infrastructure/testdriver/actions/multiDevice.html [ Failure Timeout ]
crbug.com/893480 external/wpt/pointerevents/pointerevent_touch-action-keyboard.html [ Failure Timeout ] crbug.com/893480 external/wpt/pointerevents/pointerevent_touch-action-keyboard.html [ Failure Timeout ]
...@@ -3283,12 +3284,6 @@ crbug.com/626703 [ Win ] external/wpt/content-dpr/content-dpr-various-elements.h ...@@ -3283,12 +3284,6 @@ crbug.com/626703 [ Win ] external/wpt/content-dpr/content-dpr-various-elements.h
crbug.com/626703 [ Linux ] external/wpt/websockets/opening-handshake/005.html [ Timeout ] crbug.com/626703 [ Linux ] external/wpt/websockets/opening-handshake/005.html [ Timeout ]
crbug.com/626703 [ Mac ] external/wpt/websockets/opening-handshake/005.html [ Timeout ] crbug.com/626703 [ Mac ] external/wpt/websockets/opening-handshake/005.html [ Timeout ]
crbug.com/626703 [ Win ] external/wpt/websockets/opening-handshake/005.html [ Timeout ] crbug.com/626703 [ Win ] external/wpt/websockets/opening-handshake/005.html [ Timeout ]
crbug.com/626703 [ Linux ] external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Mac ] external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Win ] external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Linux ] virtual/web-components-v0-disabled/external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Mac ] virtual/web-components-v0-disabled/external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Win ] virtual/web-components-v0-disabled/external/wpt/html/semantics/forms/the-input-element/maxlength-number.html [ Timeout ]
crbug.com/626703 [ Linux ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ] crbug.com/626703 [ Linux ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ]
crbug.com/626703 [ Mac ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ] crbug.com/626703 [ Mac ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ]
crbug.com/626703 [ Win ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ] crbug.com/626703 [ Win ] external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html [ Timeout ]
...@@ -3606,7 +3601,6 @@ crbug.com/626703 external/wpt/html/semantics/scripting-1/the-script-element/modu ...@@ -3606,7 +3601,6 @@ crbug.com/626703 external/wpt/html/semantics/scripting-1/the-script-element/modu
crbug.com/626703 external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/no-active-script-manual-module.html [ Timeout ] crbug.com/626703 external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/no-active-script-manual-module.html [ Timeout ]
crbug.com/626703 external/wpt/html/webappapis/user-prompts/newline-normalization-manual.html [ Skip ] crbug.com/626703 external/wpt/html/webappapis/user-prompts/newline-normalization-manual.html [ Skip ]
crbug.com/626703 [ Mac ] external/wpt/infrastructure/testdriver/actions/pause.html [ Pass Timeout ] crbug.com/626703 [ Mac ] external/wpt/infrastructure/testdriver/actions/pause.html [ Pass Timeout ]
crbug.com/626703 external/wpt/infrastructure/testdriver/actions/eventOrder.html [ Timeout ]
crbug.com/626703 external/wpt/css/css-text/writing-system/writing-system-text-transform-001.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/writing-system/writing-system-text-transform-001.html [ Failure ]
crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-combined-001.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-combined-001.html [ Failure ]
crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-blur.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-blur.html [ Failure ]
......
This is a testharness.js-based test.
FAIL TestDriver send keys method assert_unreached: send keys failed Reached unreachable code
Harness: the test ran to completion.
...@@ -97,29 +97,30 @@ ...@@ -97,29 +97,30 @@
eventSender.mouseUp(); eventSender.mouseUp();
return; return;
} }
if (keys.length > 1)
reject(new Error("No support for a sequence of multiple keys"));
let eventSenderKeys = keys;
let charCode = keys.charCodeAt(0);
// See https://w3c.github.io/webdriver/#keyboard-actions and
// EventSender::KeyDown().
if (charCode == 0xE004) {
eventSenderKeys = "Tab";
} else if (charCode == 0xE050) {
eventSenderKeys = "ShiftRight";
} else if (charCode == 0xE012) {
eventSenderKeys = "ArrowLeft";
} else if (charCode == 0xE013) {
eventSenderKeys = "ArrowUp";
} else if (charCode == 0xE014) {
eventSenderKeys = "ArrowRight";
} else if (charCode == 0xE015) {
eventSenderKeys = "ArrowDown";
} else if (charCode >= 0xE000 && charCode <= 0xF8FF) {
reject(new Error("No support for this code: U+" + charCode.toString(16)));
}
window.requestAnimationFrame(() => { window.requestAnimationFrame(() => {
window.eventSender.keyDown(eventSenderKeys); for(var i = 0; i < keys.length; ++i) {
let eventSenderKeys = keys[i];
let charCode = keys.charCodeAt(i);
// See https://w3c.github.io/webdriver/#keyboard-actions and
// EventSender::KeyDown().
if (charCode == 0xE004) {
eventSenderKeys = "Tab";
} else if (charCode == 0xE050) {
eventSenderKeys = "ShiftRight";
} else if (charCode == 0xE012) {
eventSenderKeys = "ArrowLeft";
} else if (charCode == 0xE013) {
eventSenderKeys = "ArrowUp";
} else if (charCode == 0xE014) {
eventSenderKeys = "ArrowRight";
} else if (charCode == 0xE015) {
eventSenderKeys = "ArrowDown";
} else if (charCode >= 0xE000 && charCode <= 0xF8FF) {
reject(new Error("No support for this code: U+" + charCode.toString(16)));
return;
}
window.eventSender.keyDown(eventSenderKeys);
}
resolve(); resolve();
}); });
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment