Commit d184b92e authored by Jarryd's avatar Jarryd Committed by Commit Bot

AllSites: Clean up obsolete histogram.

AllSitesActions has been replaced by AllSitesActions2 since M82. Because
of this, this histogram does not need a renewed expiry.

Bug: 1055444
Change-Id: I323d83ef6303771340506a5dbc3bd0daf010064d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250169Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779626}
parent 7f06a198
......@@ -14,7 +14,6 @@ settings_namespace_rewrites = [
"settings.AccountManagerBrowserProxy|AccountManagerBrowserProxy",
"settings.Account|Account",
"settings.ALL_SITES_DIALOG|ALL_SITES_DIALOG",
"settings.AllSitesAction|AllSitesAction",
"settings.AllSitesAction2|AllSitesAction2",
"settings.AndroidInfoBrowserProxy|AndroidInfoBrowserProxy",
"settings.AndroidSmsInfo|AndroidSmsInfo",
......
......@@ -117,20 +117,6 @@ const ALL_SITES = 'all-sites';
*/
export const INVALID_CATEGORY_SUBTYPE = '';
/**
* Contains the record action types logged before M82.
* This should be kept in sync with the |AllSitesAction| enum in
* chrome/browser/ui/webui/settings/site_settings_handler.cc
* @enum {number}
*/
export const AllSitesAction = {
LOAD_PAGE: 0,
RESET_PERMISSIONS: 1,
CLEAR_DATA: 2,
ENTER_SITE_DETAILS: 3,
};
/**
* Contains the possible record action types.
* This should be kept in sync with the |AllSitesAction2| enum in
......
......@@ -16,7 +16,7 @@ import {html, Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bun
import {routes} from '../route.js';
import {Route, RouteObserverBehavior, Router} from '../router.m.js';
import {AllSitesAction, ContentSetting, ContentSettingsTypes, SiteSettingSource} from '../site_settings/constants.js';
import {AllSitesAction2, ContentSetting, ContentSettingsTypes, SiteSettingSource} from '../site_settings/constants.js';
import {SiteSettingsBehavior} from '../site_settings/site_settings_behavior.js';
import {RawSiteException, RecentSitePermissions} from '../site_settings/site_settings_prefs_browser_proxy.js';
......@@ -302,7 +302,7 @@ Polymer({
const origin = this.recentSitePermissionsList_[e.model.index].origin;
Router.getInstance().navigateTo(
routes.SITE_SETTINGS_SITE_DETAILS, new URLSearchParams({site: origin}));
this.browserProxy.recordAction(AllSitesAction.ENTER_SITE_DETAILS);
this.browserProxy.recordAction(AllSitesAction2.ENTER_SITE_DETAILS);
this.lastSelected_ = {
index: e.model.index,
origin: e.model.item.origin,
......
......@@ -95,14 +95,6 @@ constexpr char kPlaceholder[] = "placeholder";
// These values are persisted to logs. Entries should not be renumbered and
// numeric values should never be reused.
enum class AllSitesAction {
kLoadPage = 0,
kResetPermissions = 1,
kClearData = 2,
kEnterSiteDetails = 3,
kMaxValue = kEnterSiteDetails,
};
enum class AllSitesAction2 {
kLoadPage = 0,
kResetSiteGroupPermissions = 1,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment