Commit d1986a2b authored by Zhongyi Shi's avatar Zhongyi Shi Committed by Commit Bot

Update quic flags

Change-Id: Iad96004c75e5c15e0b40ec173e0e39f8018cb6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099604
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: default avatarNick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749478}
parent 9f2ee968
...@@ -21,14 +21,8 @@ QuicTime QuicEpollClock::ApproximateNow() const { ...@@ -21,14 +21,8 @@ QuicTime QuicEpollClock::ApproximateNow() const {
QuicTime QuicEpollClock::Now() const { QuicTime QuicEpollClock::Now() const {
QuicTime now = CreateTimeFromMicroseconds(epoll_server_->NowInUsec()); QuicTime now = CreateTimeFromMicroseconds(epoll_server_->NowInUsec());
if (!GetQuicReloadableFlag(quic_monotonic_epoll_clock)) {
return now;
}
if (now <= largest_time_) { if (now <= largest_time_) {
if (now < largest_time_) {
QUIC_RELOADABLE_FLAG_COUNT(quic_monotonic_epoll_clock);
}
// Time not increasing, return |largest_time_|. // Time not increasing, return |largest_time_|.
return largest_time_; return largest_time_;
} }
......
...@@ -46,7 +46,6 @@ TEST_F(QuicEpollClockTest, NowInUsec) { ...@@ -46,7 +46,6 @@ TEST_F(QuicEpollClockTest, NowInUsec) {
} }
TEST_F(QuicEpollClockTest, MonotonicityWithRealEpollClock) { TEST_F(QuicEpollClockTest, MonotonicityWithRealEpollClock) {
SetQuicReloadableFlag(quic_monotonic_epoll_clock, true);
epoll_server::SimpleEpollServer epoll_server; epoll_server::SimpleEpollServer epoll_server;
QuicEpollClock clock(&epoll_server); QuicEpollClock clock(&epoll_server);
...@@ -70,11 +69,7 @@ TEST_F(QuicEpollClockTest, MonotonicityWithFakeEpollClock) { ...@@ -70,11 +69,7 @@ TEST_F(QuicEpollClockTest, MonotonicityWithFakeEpollClock) {
epoll_server.set_now_in_usec(90); epoll_server.set_now_in_usec(90);
quic::QuicTime now = clock.Now(); quic::QuicTime now = clock.Now();
if (GetQuicReloadableFlag(quic_monotonic_epoll_clock)) { ASSERT_EQ(last_now, now);
ASSERT_EQ(last_now, now);
} else {
ASSERT_GT(last_now, now);
}
} }
} // namespace test } // namespace test
......
...@@ -127,9 +127,6 @@ QUIC_FLAG( ...@@ -127,9 +127,6 @@ QUIC_FLAG(
FLAGS_quic_reloadable_flag_quic_bbr_no_bytes_acked_in_startup_recovery, FLAGS_quic_reloadable_flag_quic_bbr_no_bytes_acked_in_startup_recovery,
false) false)
// If true, QuicEpollClock::Now() will monotonically increase.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_monotonic_epoll_clock, true)
// If true, enables the BBS4 and BBS5 connection options, which reduce BBR's // If true, enables the BBS4 and BBS5 connection options, which reduce BBR's
// pacing rate in STARTUP as more losses occur as a fraction of CWND. // pacing rate in STARTUP as more losses occur as a fraction of CWND.
QUIC_FLAG(bool, QUIC_FLAG(bool,
...@@ -276,10 +273,6 @@ QUIC_FLAG(bool, ...@@ -276,10 +273,6 @@ QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_ack_delay_alarm_granularity, FLAGS_quic_reloadable_flag_quic_ack_delay_alarm_granularity,
false) false)
// If true, enable the 1ACK connection option to only send 1 immediate ACK after
// reordering.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_one_immediate_ack, true)
// If true, QuicSentPacketManager::SetSendAlgorithm(CongestionControlType) will // If true, QuicSentPacketManager::SetSendAlgorithm(CongestionControlType) will
// become a no-op if the current and the requested cc_type are the same. // become a no-op if the current and the requested cc_type are the same.
QUIC_FLAG( QUIC_FLAG(
...@@ -316,7 +309,7 @@ QUIC_FLAG(bool, ...@@ -316,7 +309,7 @@ QUIC_FLAG(bool,
// is bundled with ACKs sent after the PTO fires. // is bundled with ACKs sent after the PTO fires.
QUIC_FLAG(bool, QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_bundle_retransmittable_with_pto_ack, FLAGS_quic_reloadable_flag_quic_bundle_retransmittable_with_pto_ack,
false) true)
// If true, use QuicClock::Now() as the source of packet receive time instead of // If true, use QuicClock::Now() as the source of packet receive time instead of
// WallNow(). // WallNow().
QUIC_FLAG(bool, QUIC_FLAG(bool,
...@@ -351,7 +344,7 @@ QUIC_FLAG(bool, ...@@ -351,7 +344,7 @@ QUIC_FLAG(bool,
QUIC_FLAG( QUIC_FLAG(
bool, bool,
FLAGS_quic_reloadable_flag_quic_minimum_validation_of_coalesced_packets, FLAGS_quic_reloadable_flag_quic_minimum_validation_of_coalesced_packets,
false) true)
// If true, do not send WINDOW_UPDATE if connection has been disconnected. // If true, do not send WINDOW_UPDATE if connection has been disconnected.
QUIC_FLAG(bool, QUIC_FLAG(bool,
...@@ -361,21 +354,21 @@ QUIC_FLAG(bool, ...@@ -361,21 +354,21 @@ QUIC_FLAG(bool,
// If true, arm the 1st PTO with earliest in flight sent time. // If true, arm the 1st PTO with earliest in flight sent time.
QUIC_FLAG(bool, QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_arm_pto_with_earliest_sent_time, FLAGS_quic_reloadable_flag_quic_arm_pto_with_earliest_sent_time,
false) true)
// If true, QuicSession::WritevData() will support writing data at a specified // If true, QuicSession::WritevData() will support writing data at a specified
// encryption level. // encryption level.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_writevdata_at_level, false) QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_writevdata_at_level, true)
// If true, use standard deviation when calculating PTO timeout. // If true, use standard deviation when calculating PTO timeout.
QUIC_FLAG(bool, QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_use_standard_deviation_for_pto, FLAGS_quic_reloadable_flag_quic_use_standard_deviation_for_pto,
false) true)
// If true, QUIC BBRv2 to avoid unnecessary PROBE_RTTs after quiescence. // If true, QUIC BBRv2 to avoid unnecessary PROBE_RTTs after quiescence.
QUIC_FLAG(bool, QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt, FLAGS_quic_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt,
false) true)
// If true, use passed in ack_frame to calculate minimum size of the serialized // If true, use passed in ack_frame to calculate minimum size of the serialized
// ACK frame. // ACK frame.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment