Slider NG: Apply LayoutObjectFactory

This CL applies LayoutObjectFactory to
RangeInputType::CreateLayoutObject() and
SliderTrackElement::CreateLayoutObject().

This CL adds LayoutObjectFactory::CreateSliderTrack()
for SliderTrackElement.
 - The function returns LayoutNGBlockFlow for LayoutNG
 - The constructor of LayoutSliderTrack should take Element*.
   CreateObject<> requires it.

This CL has no behavior changes because
RangeInputType::TypeShouldForceLegacyLayout() still returns |true|.

Bug: 1040826
Change-Id: Id4ba89f09e5ff16f6b5f1f7d5c477162395beaff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419091
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808452}

third_party/blink/renderer/core/html/forms/range_input_type.cc

@@ -52,7 +52,8 @@
 #include "third_party/blink/renderer/core/html/shadow/shadow_element_names.h"
 #include "third_party/blink/renderer/core/html_names.h"
 #include "third_party/blink/renderer/core/input_type_names.h"
-#include "third_party/blink/renderer/core/layout/layout_flexible_box.h"
+#include "third_party/blink/renderer/core/layout/layout_block.h"
+#include "third_party/blink/renderer/core/layout/layout_object_factory.h"
 #include "third_party/blink/renderer/platform/bindings/exception_state.h"
 #include "third_party/blink/renderer/platform/heap/heap.h"
 #include "third_party/blink/renderer/platform/instrumentation/use_counter.h"
@@ -258,13 +259,13 @@ bool RangeInputType::TypeShouldForceLegacyLayout() const {
   return true;
 }
 
-LayoutObject* RangeInputType::CreateLayoutObject(const ComputedStyle&,
-                                                 LegacyLayout) const {
+LayoutObject* RangeInputType::CreateLayoutObject(const ComputedStyle& style,
+                                                 LegacyLayout legacy) const {
   UseCounter::Count(GetElement().GetDocument(),
                     WebFeature::kLegacyLayoutBySlider);
   // TODO(crbug.com/1040826): input[type=range] should not use
   // LayoutFlexibleBox.
-  return new LayoutFlexibleBox(&GetElement());
+  return LayoutObjectFactory::CreateFlexibleBox(GetElement(), style, legacy);
 }
 
 Decimal RangeInputType::ParseToNumber(const String& src,

third_party/blink/renderer/core/html/forms/slider_track_element.cc

@@ -4,7 +4,7 @@
 
 #include "third_party/blink/renderer/core/html/forms/slider_track_element.h"
 
-#include "third_party/blink/renderer/core/layout/layout_slider_track.h"
+#include "third_party/blink/renderer/core/layout/layout_object_factory.h"
 
 namespace blink {
 
@@ -13,7 +13,7 @@ SliderTrackElement::SliderTrackElement(Document& document)
 
 LayoutObject* SliderTrackElement::CreateLayoutObject(const ComputedStyle& style,
                                                      LegacyLayout legacy) {
-  return new LayoutSliderTrack(this);
+  return LayoutObjectFactory::CreateSliderTrack(*this, style, legacy);
 }
 
 }  // namespace blink

third_party/blink/renderer/core/layout/layout_object_factory.cc

@@ -17,6 +17,7 @@
 #include "third_party/blink/renderer/core/layout/layout_list_item.h"
 #include "third_party/blink/renderer/core/layout/layout_list_marker.h"
 #include "third_party/blink/renderer/core/layout/layout_outside_list_marker.h"
+#include "third_party/blink/renderer/core/layout/layout_slider_track.h"
 #include "third_party/blink/renderer/core/layout/layout_table.h"
 #include "third_party/blink/renderer/core/layout/layout_table_caption.h"
 #include "third_party/blink/renderer/core/layout/layout_table_cell.h"
@@ -264,6 +265,13 @@ LayoutBlockFlow* LayoutObjectFactory::CreateFileUploadControl(
                       LayoutFileUploadControl>(node, style, legacy);
 }
 
+LayoutObject* LayoutObjectFactory::CreateSliderTrack(Node& node,
+                                                     const ComputedStyle& style,
+                                                     LegacyLayout legacy) {
+  return CreateObject<LayoutBlock, LayoutNGBlockFlow, LayoutSliderTrack>(
+      node, style, legacy);
+}
+
 LayoutText* LayoutObjectFactory::CreateText(Node* node,
                                             scoped_refptr<StringImpl> str,
                                             LegacyLayout legacy) {

third_party/blink/renderer/core/layout/layout_object_factory.h

@@ -73,6 +73,9 @@ class LayoutObjectFactory {
   static LayoutBlockFlow* CreateFileUploadControl(Node& node,
                                                   const ComputedStyle& style,
                                                   LegacyLayout legacy);
+  static LayoutObject* CreateSliderTrack(Node& node,
+                                         const ComputedStyle& style,
+                                         LegacyLayout legacy);
 
   static LayoutText* CreateText(Node*, scoped_refptr<StringImpl>, LegacyLayout);
   static LayoutTextFragment* CreateTextFragment(Node*,

third_party/blink/renderer/core/layout/layout_slider_track.cc

@@ -33,12 +33,11 @@
 
 #include "third_party/blink/renderer/core/dom/shadow_root.h"
 #include "third_party/blink/renderer/core/html/forms/html_input_element.h"
-#include "third_party/blink/renderer/core/html/forms/slider_track_element.h"
 #include "third_party/blink/renderer/core/html/shadow/shadow_element_names.h"
 
 namespace blink {
 
-LayoutSliderTrack::LayoutSliderTrack(SliderTrackElement* element)
+LayoutSliderTrack::LayoutSliderTrack(Element* element)
     : LayoutBlockFlow(element) {}
 
 void LayoutSliderTrack::UpdateLayout() {

third_party/blink/renderer/core/layout/layout_slider_track.h

@@ -36,11 +36,9 @@
 
 namespace blink {
 
-class SliderTrackElement;
-
 class LayoutSliderTrack final : public LayoutBlockFlow {
  public:
-  explicit LayoutSliderTrack(SliderTrackElement*);
+  explicit LayoutSliderTrack(Element*);
 
  private:
   void UpdateLayout() override;