Commit d1e429b7 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

BoxedV8Module: Mark as final

Mark BoxedV8Module as final to avoid problems when having no virtual destructor
which depends on TraceWrapperV8Reference.

Change-Id: Ibab44d1c52f87bc099c0eca7602b175345e4cb2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841632
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702896}
parent 349b28b5
......@@ -18,7 +18,7 @@ namespace blink {
// Hash of Member<BoxedV8Module> overrides HashTraits.
// Therefore, BoxedV8Module can be a key/value type of WTF::HashMap,
// HashSet,HashTable by using BoxedV8ModuleHash.
class CORE_EXPORT BoxedV8Module : public GarbageCollected<BoxedV8Module> {
class CORE_EXPORT BoxedV8Module final : public GarbageCollected<BoxedV8Module> {
public:
BoxedV8Module(v8::Isolate* isolate, v8::Local<v8::Module> module)
: record_(isolate, module),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment