Revert "[DFM] Defer ModuleUtil.recordModuleAvailability() call to onFinishNativeInitialization()."
This reverts commit c8af0e6f. Reason for revert: The fix is effective for local build, but not Canary. Also, a better fix is available. Reverting this first simplifies merge into trunk. Original change's description: > [DFM] Defer ModuleUtil.recordModuleAvailability() call to onFinishNativeInitialization(). > > Previously, ModuleUtil.recordModuleAvailability() was called from > ChromeApplication.attachBaseContext(). A side-effect of MU.rMA() is that > it initializes SplitCompat. However, for yet-to-be determined reason, > this early initialization causes failure downstream in > ChromeContentBrowserClient, so that if a DevUI page is loaded as the > active page, restarting Chrome would cause it to fail to load! > > This CL alleviates the problem by deferring the MU.rMA() call to > ChromeBrowserInitializer.onFinishNativeInitialization(), thereby > avoiding initializing SplitCompat too early, while still recording > module metrics at start-up. > > Bug: 1036753 > Change-Id: I21c02dc957f494fb76c959c772a6f77db8b933a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003253 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732158} TBR=yfriedman@chromium.org,huangs@chromium.org,wnwen@chromium.org NOTRY=true Bug: 1036753 Change-Id: I2d566cb8b34f8f409b74a072a079706bf042f4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011440Reviewed-by:Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733493}
Showing
Please register or sign in to comment