Commit d1f6fbe1 authored by Minggang Wang's avatar Minggang Wang Committed by Commit Bot

Enable ServiceWorkerTaskProviderBrowserTest.CreateTasksForOffTheRecordProfile

The case, CreateTasksForOffTheRecordProfile, becomes flaky recently and has
been disabled on asan.

This patch enables it again by cleaning up the default browser before
the test is going to start.

Bug: 1016901
Change-Id: I52ddb58956a881409c70bb21132db066d271809f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880536Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#709826}
parent 19c1d403
......@@ -198,20 +198,16 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTaskProviderBrowserTest,
// If the profile is off the record, the ServiceWorkerTaskProvider can still
// grab the correct information and create/delete the task.
// TODO(crbug/1016901): Flaky leaks on ASAN builds.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_CreateTasksForOffTheRecordProfile \
DISABLED_CreateTasksForOffTheRecordProfile
#else
#define MAYBE_CreateTasksForOffTheRecordProfile \
CreateTasksForOffTheRecordProfile
#endif
IN_PROC_BROWSER_TEST_F(ServiceWorkerTaskProviderBrowserTest,
MAYBE_CreateTasksForOffTheRecordProfile) {
CreateTasksForOffTheRecordProfile) {
StartUpdating();
EXPECT_TRUE(tasks().empty());
Browser* incognito = CreateIncognitoBrowser();
// Close the default browser.
CloseBrowserSynchronously(browser());
ui_test_utils::NavigateToURL(
incognito, embedded_test_server()->GetURL(
"/service_worker/create_service_worker.html"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment