Commit d21cd662 authored by Vlad Tsyrklevich's avatar Vlad Tsyrklevich Committed by Commit Bot

SafeStack: Remove oilpan support

SafeStack support has been abandoned.

Bug: 908597
Change-Id: I800af0440054fb4de593a01af347b9b341cc55e5
Reviewed-on: https://chromium-review.googlesource.com/c/1351778
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611543}
parent 19739ae1
...@@ -171,12 +171,6 @@ ThreadState::ThreadState() ...@@ -171,12 +171,6 @@ ThreadState::ThreadState()
weak_persistent_region_(std::make_unique<PersistentRegion>()), weak_persistent_region_(std::make_unique<PersistentRegion>()),
start_of_stack_(reinterpret_cast<intptr_t*>(WTF::GetStackStart())), start_of_stack_(reinterpret_cast<intptr_t*>(WTF::GetStackStart())),
end_of_stack_(reinterpret_cast<intptr_t*>(WTF::GetStackStart())), end_of_stack_(reinterpret_cast<intptr_t*>(WTF::GetStackStart())),
#if HAS_FEATURE(safe_stack)
start_of_unsafe_stack_(
reinterpret_cast<intptr_t*>(__builtin___get_unsafe_stack_top())),
end_of_unsafe_stack_(
reinterpret_cast<intptr_t*>(__builtin___get_unsafe_stack_bottom())),
#endif
sweep_forbidden_(false), sweep_forbidden_(false),
no_allocation_count_(0), no_allocation_count_(0),
gc_forbidden_count_(0), gc_forbidden_count_(0),
...@@ -347,19 +341,6 @@ void ThreadState::VisitStack(MarkingVisitor* visitor) { ...@@ -347,19 +341,6 @@ void ThreadState::VisitStack(MarkingVisitor* visitor) {
heap_->CheckAndMarkPointer(visitor, ptr); heap_->CheckAndMarkPointer(visitor, ptr);
VisitAsanFakeStackForPointer(visitor, ptr); VisitAsanFakeStackForPointer(visitor, ptr);
} }
#if HAS_FEATURE(safe_stack)
start = reinterpret_cast<Address*>(start_of_unsafe_stack_);
end = reinterpret_cast<Address*>(end_of_unsafe_stack_);
current = end;
for (; current < start; ++current) {
Address ptr = *current;
// SafeStack And MSan are not compatible
heap_->CheckAndMarkPointer(visitor, ptr);
VisitAsanFakeStackForPointer(visitor, ptr);
}
#endif
} }
void ThreadState::VisitDOMWrappers(Visitor* visitor) { void ThreadState::VisitDOMWrappers(Visitor* visitor) {
...@@ -1309,10 +1290,6 @@ extern "C" void PushAllRegisters(void*, ThreadState*, PushAllRegistersCallback); ...@@ -1309,10 +1290,6 @@ extern "C" void PushAllRegisters(void*, ThreadState*, PushAllRegistersCallback);
static void DidPushRegisters(void*, ThreadState* state, intptr_t* stack_end) { static void DidPushRegisters(void*, ThreadState* state, intptr_t* stack_end) {
state->RecordStackEnd(stack_end); state->RecordStackEnd(stack_end);
#if HAS_FEATURE(safe_stack)
state->RecordUnsafeStackEnd(
reinterpret_cast<intptr_t*>(__builtin___get_unsafe_stack_ptr()));
#endif
} }
void ThreadState::PushRegistersAndVisitStack() { void ThreadState::PushRegistersAndVisitStack() {
......
...@@ -420,11 +420,6 @@ class PLATFORM_EXPORT ThreadState final ...@@ -420,11 +420,6 @@ class PLATFORM_EXPORT ThreadState final
void SafePoint(BlinkGC::StackState); void SafePoint(BlinkGC::StackState);
void RecordStackEnd(intptr_t* end_of_stack) { end_of_stack_ = end_of_stack; } void RecordStackEnd(intptr_t* end_of_stack) { end_of_stack_ = end_of_stack; }
#if HAS_FEATURE(safe_stack)
void RecordUnsafeStackEnd(intptr_t* end_of_unsafe_stack) {
end_of_unsafe_stack_ = end_of_unsafe_stack;
}
#endif
void PushRegistersAndVisitStack(); void PushRegistersAndVisitStack();
...@@ -700,11 +695,6 @@ class PLATFORM_EXPORT ThreadState final ...@@ -700,11 +695,6 @@ class PLATFORM_EXPORT ThreadState final
intptr_t* start_of_stack_; intptr_t* start_of_stack_;
intptr_t* end_of_stack_; intptr_t* end_of_stack_;
#if HAS_FEATURE(safe_stack)
intptr_t* start_of_unsafe_stack_;
intptr_t* end_of_unsafe_stack_;
#endif
bool sweep_forbidden_; bool sweep_forbidden_;
size_t no_allocation_count_; size_t no_allocation_count_;
size_t gc_forbidden_count_; size_t gc_forbidden_count_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment