Commit d231545e authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove origin header manipulation from RenderFrameImpl

The origin header manipulation was introduced at
https://codereview.chromium.org/343273005.

As we are moving CORS to services/network, let's stop manipulation
origin header in renderer.

This fixes origin header for GET-nor-HEAD request from extensions.

Bug: 967630, 595993
Change-Id: I5bb5342ebceb133aa726ebc9125f6c1a5f71a0c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633869
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664114}
parent 5dfa177e
......@@ -5275,10 +5275,6 @@ void RenderFrameImpl::WillSendRequestInternal(
old_extra_data->TakeNavigationResponseOverrideOwnership();
}
// Set an empty HTTP origin header for non GET methods if none is currently
// present.
request.SetHttpOriginIfNeeded(WebSecurityOrigin::CreateUnique());
WebDocument frame_document = frame_->GetDocument();
if (!request.GetExtraData())
request.SetExtraData(std::make_unique<RequestExtraData>());
......
This is a testharness.js-based test.
PASS initialize global state
FAIL event.request has the expected headers for same-origin GET. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for same-origin GET. lengths differ, expected 1 got 3"
FAIL event.request has the expected headers for same-origin POST. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for same-origin POST. lengths differ, expected 2 got 5"
FAIL event.request has the expected headers for same-origin POST. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for same-origin POST. lengths differ, expected 2 got 4"
FAIL event.request has the expected headers for cross-origin GET. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for cross-origin GET. lengths differ, expected 1 got 3"
FAIL event.request has the expected headers for cross-origin POST. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for cross-origin POST. lengths differ, expected 2 got 5"
FAIL event.request has the expected headers for cross-origin POST. promise_test: Unhandled rejection with value: object "Error: assert_array_equals: event.request has the expected headers for cross-origin POST. lengths differ, expected 2 got 4"
PASS FetchEvent#request.body contains XHR request data (string)
PASS FetchEvent#request.body contains XHR request data (blob)
PASS FetchEvent#request.method is set to XHR method
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment