Revert "Speculative CHECK to pinpoint crash."
This reverts commit 0a610db7. Reason for revert: The same stack trace still appears on new crashes. Original change's description: > Speculative CHECK to pinpoint crash. > > The issue below correlates to element_under_pointer_.at returning a > nullptr. All calls to element_under_pointer_.at but one are prefaced > with an if(element_under_pointer_.Contains(...)) check. > That one call is prefaced with a DCHECK. Most likely culprit is that > there is a real-world case in which the DCHECK doesn't hold and is > not covered by our tests. > Making the DCHECK a CHECK should confirm that. We'd still get the > same number of crashes overall, but with a different stacktrace. > > Bug: 1114579 > Change-Id: Ie28c971ed2114cf4a780f9eb5366c60d7669315c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359081 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798657} TBR=haraken@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114579 Change-Id: I9ff7e81bbe50484718ced3fd1cc97f900427be07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372366Reviewed-by:Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801029}
Showing
Please register or sign in to comment