Commit d26d3695 authored by Lijin Shen's avatar Lijin Shen Committed by Commit Bot

Rename menu_badge_transition_y_distance and remove comments

Some followup mentioned in https://crrev.com/c/1829245.

Bug: 1033715
Change-Id: Ic4f1641f9c6f8db0e051788249eee701ea86e791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966246Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#726978}
parent 936d49d0
...@@ -58,7 +58,7 @@ ...@@ -58,7 +58,7 @@
<dimen name="tab_switcher_menu_width">222dp</dimen> <dimen name="tab_switcher_menu_width">222dp</dimen>
<dimen name="tab_switcher_menu_vertical_padding">8dp</dimen> <dimen name="tab_switcher_menu_vertical_padding">8dp</dimen>
<dimen name="menu_badge_translation_y_distance">6dp</dimen> <dimen name="menu_badge_translation_y">6dp</dimen>
<!-- Infobar dimensions --> <!-- Infobar dimensions -->
<!-- Text size of the infobar message and other controls. --> <!-- Text size of the infobar message and other controls. -->
......
...@@ -151,7 +151,6 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo ...@@ -151,7 +151,6 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
if (mDelegate != null) mDelegate.removeUIObserver(this); if (mDelegate != null) mDelegate.removeUIObserver(this);
} }
// TODO(lazzzis): try to clean up reference to mLocation if position.
private ModelList getItems() { private ModelList getItems() {
// Rebuild listItems, cause mLocation may be changed anytime. // Rebuild listItems, cause mLocation may be changed anytime.
boolean canMove = false; boolean canMove = false;
...@@ -310,4 +309,4 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo ...@@ -310,4 +309,4 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
super.onClick(view); super.onClick(view);
} }
} }
} }
\ No newline at end of file
...@@ -294,7 +294,7 @@ public class MenuButton extends FrameLayout implements TintObserver { ...@@ -294,7 +294,7 @@ public class MenuButton extends FrameLayout implements TintObserver {
badgeFadeAnimator.setInterpolator(BakedBezierInterpolator.FADE_IN_CURVE); badgeFadeAnimator.setInterpolator(BakedBezierInterpolator.FADE_IN_CURVE);
int pixelTranslation = menuBadge.getResources().getDimensionPixelSize( int pixelTranslation = menuBadge.getResources().getDimensionPixelSize(
R.dimen.menu_badge_translation_y_distance); R.dimen.menu_badge_translation_y);
ObjectAnimator badgeTranslateYAnimator = ObjectAnimator badgeTranslateYAnimator =
ObjectAnimator.ofFloat(menuBadge, View.TRANSLATION_Y, pixelTranslation, 0.f); ObjectAnimator.ofFloat(menuBadge, View.TRANSLATION_Y, pixelTranslation, 0.f);
badgeTranslateYAnimator.setInterpolator(BakedBezierInterpolator.TRANSFORM_CURVE); badgeTranslateYAnimator.setInterpolator(BakedBezierInterpolator.TRANSFORM_CURVE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment