Commit d294e5dc authored by Dominic Battré's avatar Dominic Battré Committed by Commit Bot

Revert "Disable SubframeNavigationFilteringThrottleTest.FilterOnRedirect"

This reverts commit 89a29df6.

Reason for revert: Disabling is non-actionable, see crbug.com/1010061#c11

Original change's description:
> Disable SubframeNavigationFilteringThrottleTest.FilterOnRedirect
> 
> TBR=jyasskin@chromium.org
> NOTRY=true
> 
> Bug: 1010061
> Change-Id: Ie2519fec6a3faaf65437dcc218699b5b8a666fea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833294
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701628}

TBR=jyasskin@chromium.org,xidachen@chromium.org

Change-Id: I9b81a939174a31c0cd001a630ec9d647b6b17191
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1010061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834186Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701920}
parent c2cfc78d
...@@ -164,8 +164,12 @@ TEST_F(SubframeNavigationFilteringThrottleTest, FilterOnStart) { ...@@ -164,8 +164,12 @@ TEST_F(SubframeNavigationFilteringThrottleTest, FilterOnStart) {
base::Contains(GetConsoleMessages(), GetFilterConsoleMessage(url))); base::Contains(GetConsoleMessages(), GetFilterConsoleMessage(url)));
} }
// crbug.com/1010061: disabled due to flakiness, #if defined(OS_MACOSX)
TEST_F(SubframeNavigationFilteringThrottleTest, DISABLED_FilterOnRedirect) { #define MAYBE_FilterOnRedirect DISABLED_FilterOnRedirect
#else
#define MAYBE_FilterOnRedirect FilterOnRedirect
#endif
TEST_F(SubframeNavigationFilteringThrottleTest, MAYBE_FilterOnRedirect) {
InitializeDocumentSubresourceFilter(GURL("https://example.test")); InitializeDocumentSubresourceFilter(GURL("https://example.test"));
CreateTestSubframeAndInitNavigation(GURL("https://example.test/allowed.html"), CreateTestSubframeAndInitNavigation(GURL("https://example.test/allowed.html"),
main_rfh()); main_rfh());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment