Commit d29523e9 authored by Dmitry Gozman's avatar Dmitry Gozman Committed by Commit Bot

Fix race in headless protocol tests

We should wait for Runtime.addBinding to finish
before proceeding with the test.

Bug: none
Change-Id: I06be299d5f74c69818b92c09eaea6c422ac0bed2
Reviewed-on: https://chromium-review.googlesource.com/c/1483361Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634782}
parent 5153a4ca
......@@ -66,18 +66,19 @@ class HeadlessProtocolBrowserTest
private:
// HeadlessWebContentsObserver implementation.
void DevToolsTargetReady() override {
HeadlessAsyncDevTooledBrowserTest::DevToolsTargetReady();
void RunDevTooledTest() override {
browser_devtools_client_->SetRawProtocolListener(this);
devtools_client_->GetRuntime()->GetExperimental()->AddObserver(this);
devtools_client_->GetRuntime()->Enable();
devtools_client_->GetRuntime()->GetExperimental()->AddBinding(
headless::runtime::AddBindingParams::Builder()
.SetName("sendProtocolMessage")
.Build());
browser_devtools_client_->SetRawProtocolListener(this);
.Build(),
base::BindOnce(&HeadlessProtocolBrowserTest::BindingCreated,
base::Unretained(this)));
}
void RunDevTooledTest() override {
void BindingCreated(std::unique_ptr<headless::runtime::AddBindingResult>) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath src_dir;
CHECK(base::PathService::Get(base::DIR_SOURCE_ROOT, &src_dir));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment