Commit d2966799 authored by rockot's avatar rockot Committed by Commit bot

Always set bad_message_reason when logging bad message dumps

The crash key was accidentally left unset when bad message dumps
were moved to the IO thread. This fixes that.

BUG=680542
R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2629773002
Cr-Commit-Position: refs/heads/master@{#443440}
parent 4b184ca0
...@@ -33,8 +33,6 @@ void ReceivedBadMessageOnUIThread(int render_process_id, ...@@ -33,8 +33,6 @@ void ReceivedBadMessageOnUIThread(int render_process_id,
if (!host) if (!host)
return; return;
LogBadMessage(reason);
// A dump has already been generated by the caller. Don't generate another. // A dump has already been generated by the caller. Don't generate another.
host->ShutdownForBadMessage( host->ShutdownForBadMessage(
RenderProcessHost::CrashReportMode::NO_CRASH_DUMP); RenderProcessHost::CrashReportMode::NO_CRASH_DUMP);
...@@ -49,8 +47,9 @@ void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason) { ...@@ -49,8 +47,9 @@ void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason) {
} }
void ReceivedBadMessage(int render_process_id, BadMessageReason reason) { void ReceivedBadMessage(int render_process_id, BadMessageReason reason) {
// We generate a crash dump here since generating one after posting the UI // We generate a crash dump here since generating one after posting to the UI
// thread is mostly useless. // thread is less useful.
LogBadMessage(reason);
base::debug::DumpWithoutCrashing(); base::debug::DumpWithoutCrashing();
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment