Commit d29bb8a2 authored by pmonette's avatar pmonette Committed by Commit bot

Remove some useless code in TabsEventRouter.

The TabStripModel is no longer needed inside the event
handlers.

Review-Url: https://codereview.chromium.org/2339393003
Cr-Commit-Position: refs/heads/master@{#419063}
parent 93f5f005
...@@ -507,14 +507,9 @@ void TabsEventRouter::TabReplacedAt(TabStripModel* tab_strip_model, ...@@ -507,14 +507,9 @@ void TabsEventRouter::TabReplacedAt(TabStripModel* tab_strip_model,
} }
void TabsEventRouter::TabPinnedStateChanged(WebContents* contents, int index) { void TabsEventRouter::TabPinnedStateChanged(WebContents* contents, int index) {
TabStripModel* tab_strip = NULL; std::set<std::string> changed_property_names;
int tab_index; changed_property_names.insert(tabs_constants::kPinnedKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
if (ExtensionTabUtil::GetTabStripModel(contents, &tab_strip, &tab_index)) {
std::set<std::string> changed_property_names;
changed_property_names.insert(tabs_constants::kPinnedKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
}
} }
void TabsEventRouter::OnZoomChanged( void TabsEventRouter::OnZoomChanged(
...@@ -558,26 +553,16 @@ void TabsEventRouter::OnFaviconUpdated( ...@@ -558,26 +553,16 @@ void TabsEventRouter::OnFaviconUpdated(
void TabsEventRouter::OnDiscardedStateChange(WebContents* contents, void TabsEventRouter::OnDiscardedStateChange(WebContents* contents,
bool is_discarded) { bool is_discarded) {
TabStripModel* tab_strip = nullptr; std::set<std::string> changed_property_names;
int tab_index = -1; changed_property_names.insert(tabs_constants::kDiscardedKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
if (ExtensionTabUtil::GetTabStripModel(contents, &tab_strip, &tab_index)) {
std::set<std::string> changed_property_names;
changed_property_names.insert(tabs_constants::kDiscardedKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
}
} }
void TabsEventRouter::OnAutoDiscardableStateChange(WebContents* contents, void TabsEventRouter::OnAutoDiscardableStateChange(WebContents* contents,
bool is_auto_discardable) { bool is_auto_discardable) {
TabStripModel* tab_strip = nullptr; std::set<std::string> changed_property_names;
int tab_index = -1; changed_property_names.insert(tabs_constants::kAutoDiscardableKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
if (ExtensionTabUtil::GetTabStripModel(contents, &tab_strip, &tab_index)) {
std::set<std::string> changed_property_names;
changed_property_names.insert(tabs_constants::kAutoDiscardableKey);
DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
}
} }
} // namespace extensions } // namespace extensions
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment