Commit d2ae1b0d authored by Jordy Greenblatt's avatar Jordy Greenblatt Committed by Commit Bot

Fixed inaccurate selector causing DOM focus instability.

A previous migration to using cr-link-row instead of directly using
a subpage-arrow class cr-icon-button did not update the selector in
forcusConfig_ to match. As a result, when the user routes back to the
OS search page, the DOM and a11y focus go to the full page.

This CL updates the selector in focusConfig_.

Bug: 1003992
Change-Id: I57bf325a9ea5fe4f7719924cf9c2abbedde9de9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897492
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarJordy Greenblatt <jordynass@chromium.org>
Auto-Submit: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712351}
parent 4da2fc25
...@@ -59,8 +59,7 @@ Polymer({ ...@@ -59,8 +59,7 @@ Polymer({
this.focusConfig_ = new Map(); this.focusConfig_ = new Map();
if (settings.routes.GOOGLE_ASSISTANT) { if (settings.routes.GOOGLE_ASSISTANT) {
this.focusConfig_.set( this.focusConfig_.set(
settings.routes.GOOGLE_ASSISTANT.path, settings.routes.GOOGLE_ASSISTANT.path, '#assistantSubpageTrigger');
'#assistantSubpageTrigger .subpage-arrow');
} }
}, },
......
...@@ -68,8 +68,7 @@ Polymer({ ...@@ -68,8 +68,7 @@ Polymer({
// <if expr="chromeos"> // <if expr="chromeos">
if (settings.routes.GOOGLE_ASSISTANT) { if (settings.routes.GOOGLE_ASSISTANT) {
this.focusConfig_.set( this.focusConfig_.set(
settings.routes.GOOGLE_ASSISTANT.path, settings.routes.GOOGLE_ASSISTANT.path, '#assistantSubpageTrigger');
'#assistantSubpageTrigger .subpage-arrow');
} }
// </if> // </if>
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment