Skip to content

GitLab

T
tangled
Commit d2b54b71 authored by Hugo Holgersson's avatar Hugo Holgersson Committed by Commit Bot
Browse files
Options

[SpatNav] Test that we ignore elements hidden by CSS 

We already tested offscreen elements and elements hidden
(covered) by other elements but we lacked tests for:

|opacity: 0|
|visibility: hidden|
|display: none|

This CL adds testing for all three.

Note: crrev.com/659441 recently fixed the |opacity: 0|
case. The other two were already passing.

Bug: None (as crrev.com/659441)
Change-Id: Ia20e123c4f8b9e43b2ada9aef3ce0d9ac7f29aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628612
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#663059}
parent fe5e3725
Hide whitespace changes
Inline Side-by-side
Showing with 31 additions and 0 deletions
third_party/blink/web_tests/fast/spatial-navigation/snav-ignore-hidden-or-transparent.html 0 → 100644
View file @ d2b54b71
<!doctype html>
<style>
.a {opacity: 0;}
.b {visibility: hidden;}
.c {display: none;}
</style>
<a class="a" href="www">a</a><a class="b" href="www">b</a><a class="c" href="www">c</a><br>
<a class="a" href="www">a</a><a class="b" href="www">b</a><a class="c" href="www">c</a><a id="start" href="www">start</a><a class="a" href="www">a</a><a class="b" href="www">b</a><a class="c" href="www">c</a><br>
<a class="a" href="www">a</a><a class="b" href="www">b</a><a class="c" href="www">c</a><br>
<a id="a" class="a" href="www">a</a> <a id="b" class="b" href="www">b</a>
<p>This page contains hidden elements in all directions.</p>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="resources/snav-testharness.js"></script>
<script>
var resultMap = [
["Down", "start"],
["Down", "start"],
["Up", "start"],
["Left", "start"],
["Right", "start"]
];
snav.assertFocusMoves(resultMap);
</script>
<p><em>Manual test instruction: Ensure that focus does not disappear (goes to a hidden element).</em></p>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment