Revert "Set fallback focus to the accounts and sync dialog."
This reverts commit f7e31c9d. Reason for revert: this seems to cause breakages in mac builders https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9647 Original change's description: > Set fallback focus to the accounts and sync dialog. > > Set the first container as initial focus, so focus manager will search > the first focusable item in case no other view is explicitly focused > (e.g. with Ctrl+Shift+M, focus is set to the profile list for quick > profile change). Setting focus inside the dialog is important for > accessibility: when focus changes to a view inside the dialog, screen > readers will announce the dialog to give context to the focus change. > > We don't need to override GetAccessibleWindowRole() any more because > the implementation in DialogDelegateView will set the 'dialog' role for > bubbles which have an initially focused view. > > Tests are altered to make up for the default focus change. Before, > default focus was set outside the dialog and you had to advance once > to reach the first element. Now, it's already placed on the first > element. > > Bug: 1098304 > Change-Id: Ie0db18193cb224497d311c8ae864ec4e532572b6 > AX-relnotes: set focus into, and read accounts and sync dialog when open > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475056 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> > Cr-Commit-Position: refs/heads/master@{#819287} TBR=pbos@chromium.org,jkrcal@chromium.org,rhalavati@chromium.org,jaragunde@igalia.com Change-Id: I8ad7448148905434910bd1178594e6542935ed85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489882Reviewed-by:Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819320}
Showing
Please register or sign in to comment