Don't call PaintChildren() from inside OnPaint().

OnPaint() is not part of the recursion, it won't have access to the
necessary pieces to do recursion.

If you need to do painting while inside the recursion, this should
happen in PaintChildren(). So move the contents of OnPaint() to
PaintChildren().

R=estade@chromium.org
BUG=466426

Review URL: https://codereview.chromium.org/1029263011

Cr-Commit-Position: refs/heads/master@{#322487}

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

@@ -685,8 +685,6 @@ void AutofillDialogViews::OverlayView::OnPaint(gfx::Canvas* canvas) {
     paint.setStyle(SkPaint::kStroke_Style);
     canvas->DrawPath(arrow, paint);
   }
-
-  PaintChildren(canvas, views::CullSet());
 }
 
 void AutofillDialogViews::OverlayView::OnNativeThemeChanged(
@@ -763,12 +761,7 @@ const char* AutofillDialogViews::NotificationArea::GetClassName() const {
 void AutofillDialogViews::NotificationArea::PaintChildren(
     gfx::Canvas* canvas,
     const views::CullSet& cull_set) {
-}
-
-void AutofillDialogViews::NotificationArea::OnPaint(gfx::Canvas* canvas) {
-  views::View::OnPaint(canvas);
   views::View::PaintChildren(canvas, views::CullSet());
-
   if (HasArrow()) {
     DrawArrow(
         canvas,
@@ -1002,11 +995,6 @@ const char* AutofillDialogViews::SuggestedButton::GetClassName() const {
   return kSuggestedButtonClassName;
 }
 
-void AutofillDialogViews::SuggestedButton::PaintChildren(
-    gfx::Canvas* canvas,
-    const views::CullSet& cull_set) {
-}
-
 void AutofillDialogViews::SuggestedButton::OnPaint(gfx::Canvas* canvas) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   const gfx::Insets insets = GetInsets();

chrome/browser/ui/views/autofill/autofill_dialog_views.h

@@ -263,7 +263,6 @@ class AutofillDialogViews : public AutofillDialogView,
     const char* GetClassName() const override;
     void PaintChildren(gfx::Canvas* canvas,
                        const views::CullSet& cull_set) override;
-    void OnPaint(gfx::Canvas* canvas) override;
 
     void set_arrow_centering_anchor(
         const base::WeakPtr<views::View>& arrow_centering_anchor) {
@@ -345,8 +344,6 @@ class AutofillDialogViews : public AutofillDialogView,
     // views::MenuButton implementation.
     gfx::Size GetPreferredSize() const override;
     const char* GetClassName() const override;
-    void PaintChildren(gfx::Canvas* canvas,
-                       const views::CullSet& cull_set) override;
     void OnPaint(gfx::Canvas* canvas) override;
 
    private: