Commit d2c7002c authored by lushnikov's avatar lushnikov Committed by Commit bot

DevTools: greyed-out console suggestion should not clash with console history

This patch makes greyed-out console suggestion darker. It also stops
forcing console history icon to be white in case of dimmed suggestion.

BUG=700570
R=dgozman

Review-Url: https://codereview.chromium.org/2749363002
Cr-Commit-Position: refs/heads/master@{#457477}
parent b17a05b5
...@@ -61,6 +61,8 @@ UI.SuggestBox = class { ...@@ -61,6 +61,8 @@ UI.SuggestBox = class {
this._rowHeight = 17; this._rowHeight = 17;
this._userInteracted = false; this._userInteracted = false;
this._userEnteredText = ''; this._userEnteredText = '';
this._defaultSelectionIsDimmed = false;
/** @type {?string} */ /** @type {?string} */
this._onlyCompletion = null; this._onlyCompletion = null;
...@@ -81,6 +83,7 @@ UI.SuggestBox = class { ...@@ -81,6 +83,7 @@ UI.SuggestBox = class {
* @param {boolean} value * @param {boolean} value
*/ */
setDefaultSelectionIsDimmed(value) { setDefaultSelectionIsDimmed(value) {
this._defaultSelectionIsDimmed = value;
this._element.classList.toggle('default-selection-is-dimmed', value); this._element.classList.toggle('default-selection-is-dimmed', value);
} }
...@@ -259,8 +262,11 @@ UI.SuggestBox = class { ...@@ -259,8 +262,11 @@ UI.SuggestBox = class {
selectedItemChanged(from, to, fromElement, toElement) { selectedItemChanged(from, to, fromElement, toElement) {
if (fromElement) if (fromElement)
fromElement.classList.remove('selected', 'force-white-icons'); fromElement.classList.remove('selected', 'force-white-icons');
if (toElement) if (toElement) {
toElement.classList.add('selected', 'force-white-icons'); toElement.classList.add('selected');
if (fromElement || this._userInteracted || !this._defaultSelectionIsDimmed)
toElement.classList.add('force-white-icons');
}
if (!to) if (!to)
return; return;
this._applySuggestion(true); this._applySuggestion(true);
......
...@@ -94,7 +94,7 @@ ...@@ -94,7 +94,7 @@
} }
.default-selection-is-dimmed .suggest-box-content-item.selected { .default-selection-is-dimmed .suggest-box-content-item.selected {
background-color: whitesmoke; background-color: #E0E0E0;
} }
.default-selection-is-dimmed .suggest-box-content-item.selected > span { .default-selection-is-dimmed .suggest-box-content-item.selected > span {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment