Rename AnyExecutingScriptsTaggedAsAdResource to IsAdScriptInStack

Rename to simplify the code

Bug: 807640
Change-Id: Ib7a7e76ec6db79cbd4423de60719d53f79e02926
Reviewed-on: https://chromium-review.googlesource.com/1035466Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554845}

third_party/blink/renderer/core/frame/ad_tracker.cc

@@ -84,8 +84,7 @@ void AdTracker::WillSendRequest(ExecutionContext* execution_context,
                                 Resource::Type resource_type) {
   // If the resource is not already marked as an ad, check if any executing
   // script is an ad. If yes, mark this as an ad.
-  if (!request.IsAdResource() &&
-      AnyExecutingScriptsTaggedAsAdResource(execution_context))
+  if (!request.IsAdResource() && IsAdScriptInStack(execution_context))
     request.SetIsAdResource();
 
   // If it is a script marked as an ad, append it to the known ad scripts set.
@@ -93,8 +92,7 @@ void AdTracker::WillSendRequest(ExecutionContext* execution_context,
     AppendToKnownAdScripts(request.Url());
 }
 
-bool AdTracker::AnyExecutingScriptsTaggedAsAdResource(
-    ExecutionContext* execution_context) {
+bool AdTracker::IsAdScriptInStack(ExecutionContext* execution_context) {
   // The pseudo-stack contains entry points into the stack (e.g., when v8 is
   // executed) but not the entire stack. It's cheap to retrieve the top of the
   // stack so scan that as well.

third_party/blink/renderer/core/frame/ad_tracker.h

@@ -53,7 +53,7 @@ class CORE_EXPORT AdTracker : public GarbageCollectedFinalized<AdTracker> {
 
   // Returns true if any script in the pseudo call stack have previously been
   // identified as an ad resource.
-  bool AnyExecutingScriptsTaggedAsAdResource(ExecutionContext*);
+  bool IsAdScriptInStack(ExecutionContext*);
 
   virtual void Trace(blink::Visitor*);
 

third_party/blink/renderer/core/frame/ad_tracker_test.cc

@@ -47,8 +47,7 @@ class AdTrackerTest : public testing::Test {
   }
 
   bool AnyExecutingScriptsTaggedAsAdResource() {
-    return ad_tracker_->AnyExecutingScriptsTaggedAsAdResource(
-        &page_holder_->GetDocument());
+    return ad_tracker_->IsAdScriptInStack(&page_holder_->GetDocument());
   }
 
   void AppendToKnownAdScripts(const KURL& url) {

third_party/blink/renderer/core/frame/local_frame.cc

@@ -1155,8 +1155,7 @@ bool LocalFrame::ComputeIsAdSubFrame() const {
   // it's remote, then blink relies on the embedder to call SetIsAdFrame.
   bool parent_is_ad =
       parent->IsLocalFrame() && ToLocalFrame(parent)->IsAdSubframe();
-  return parent_is_ad ||
-         ad_tracker_->AnyExecutingScriptsTaggedAsAdResource(GetDocument());
+  return parent_is_ad || ad_tracker_->IsAdScriptInStack(GetDocument());
 }
 
 service_manager::InterfaceProvider& LocalFrame::GetInterfaceProvider() {