Commit d2f1fcdc authored by vidorteg's avatar vidorteg Committed by Commit Bot

DevTools: Fixing two issues on grdp files

* Some strings were added and some were removed between this change and
 commit 613ca444 and were not present
in the grdp files, which causes presubmit errors.

* $0 as a literal was present in elemts_strings.grdp, this format is reserved
for grit placeholders. The fix is to use a placeholder to represent $0

Change-Id: I31eaa257eed9926a8809f83dc4be8b1a342c1b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637046Reviewed-by: default avatarJoel Einbinder <einbinder@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#664910}
parent 31efb562
...@@ -250,7 +250,8 @@ Elements.ElementsTreeElement = class extends UI.TreeElement { ...@@ -250,7 +250,8 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {
_createHint() { _createHint() {
if (this.listItemElement && !this._hintElement) { if (this.listItemElement && !this._hintElement) {
this._hintElement = this.listItemElement.createChild('span', 'selected-hint'); this._hintElement = this.listItemElement.createChild('span', 'selected-hint');
this._hintElement.title = Common.UIString('Use $0 in the console to refer to this element.'); const selectedElementCommand = '$0';
this._hintElement.title = ls`Use ${selectedElementCommand} in the console to refer to this element.`;
UI.ARIAUtils.markAsHidden(this._hintElement); UI.ARIAUtils.markAsHidden(this._hintElement);
} }
} }
......
...@@ -67,7 +67,7 @@ ...@@ -67,7 +67,7 @@
Delete element Delete element
</message> </message>
<message name="IDS_DEVTOOLS_3427db2c4cb9d8d61c1dd32d218d5699" desc=""> <message name="IDS_DEVTOOLS_3427db2c4cb9d8d61c1dd32d218d5699" desc="">
Use $0 in the console to refer to this element. Use <ph name="ELEMENTS_HINT">$1s</ph> in the console to refer to this element.
</message> </message>
<message name="IDS_DEVTOOLS_365fee797b55ffeac84d2ba82507b721" desc=""> <message name="IDS_DEVTOOLS_365fee797b55ffeac84d2ba82507b721" desc="">
user agent stylesheet user agent stylesheet
......
...@@ -180,6 +180,9 @@ ...@@ -180,6 +180,9 @@
<message name="IDS_DEVTOOLS_a68cfcae283e3b2a60c99386c809fd6e" desc=""> <message name="IDS_DEVTOOLS_a68cfcae283e3b2a60c99386c809fd6e" desc="">
Shift+drag horizontally to rotate around the y-axis Shift+drag horizontally to rotate around the y-axis
</message> </message>
<message name="IDS_DEVTOOLS_a7e2da1e5160847a88912b69027bca09" desc="">
Enable orientation to rotate
</message>
<message name="IDS_DEVTOOLS_a88789aba0125292a7a2b8774a979b37" desc=""> <message name="IDS_DEVTOOLS_a88789aba0125292a7a2b8774a979b37" desc="">
Geolocations Geolocations
</message> </message>
......
...@@ -15,9 +15,6 @@ ...@@ -15,9 +15,6 @@
<message name="IDS_DEVTOOLS_1023bf87beb1d2947824df00fa0898ad" desc=""> <message name="IDS_DEVTOOLS_1023bf87beb1d2947824df00fa0898ad" desc="">
Disable async stack traces Disable async stack traces
</message> </message>
<message name="IDS_DEVTOOLS_150fa516787b5e5d1d2723c84574dbee" desc="">
HTTP-Based Public Key Pinning is deprecated. Chrome 69 and later will ignore HPKP response headers. (Host: <ph name="PARSED_HOST">$1s</ph>)
</message>
<message name="IDS_DEVTOOLS_185bf49541541933dc3fd1fb89d3fea3" desc=""> <message name="IDS_DEVTOOLS_185bf49541541933dc3fd1fb89d3fea3" desc="">
Enable custom formatters Enable custom formatters
</message> </message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment